Fix get_header JSON deserialization.
#8228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmygchen
commented
Oct 16, 2025
Member
|
Nice catch! |
7 tasks
pawanjay176
previously requested changes
Oct 17, 2025
Member
pawanjay176
left a comment
pawanjay176
left a comment
There was a problem hiding this comment.
LGTM, I think we can skip the regex import in the test though
michaelsproul
added
waiting-on-author
jimmygchen
added
ready-for-review
michaelsproul
approved these changes
Oct 20, 2025
Member
michaelsproul
left a comment
michaelsproul
left a comment
There was a problem hiding this comment.
Looks good, let's merge
jimmygchen
added
ready-for-merge
6 tasks
Member
Author
|
Tested this in our infra and seeing successful builder proposals on hoodi with json payloads. 🎉 |
jchavarri
pushed a commit
to jchavarri/lighthouse
that referenced
this pull request
Oct 21, 2025
sigp#8224 Please list or describe the changes introduced by this PR. Co-Authored-By: Jimmy Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
#8224
Proposed Changes
Please list or describe the changes introduced by this PR.
Additional Info
Please provide any additional information. For example, future considerations
or information useful for reviewers.