Fix duplicate fields being logged when the field exists in both the span and the event #8183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmygchen
added
ready-for-review
…pan and the event. Prefer event fields when this happens.
jimmygchen
force-pushed
the
fix-logs-fields
branch
from
1d362d8 to
cb59682
Compare
|
Some required checks have failed. Could you please take a look @jimmygchen? 🙏 |
mergify
bot
added
waiting-on-author
jimmygchen
added
ready-for-review
jimmygchen
added a commit
to jimmygchen/lighthouse
that referenced
this pull request
Oct 10, 2025
commit bf10815 Author: Jimmy Chen <[email protected]> Date: Fri Oct 10 11:30:45 2025 +1100 Fix tests and add some tests. commit cb59682 Author: Jimmy Chen <[email protected]> Date: Fri Oct 10 00:41:17 2025 +1100 Fix duplicate fields being logged when the field exists in both the span and the event. Prefer event fields when this happens.
michaelsproul
approved these changes
Oct 13, 2025
Member
michaelsproul
left a comment
michaelsproul
left a comment
There was a problem hiding this comment.
Nice, LGTM. And test looks good
michaelsproul
added
ready-for-merge
6 tasks
jimmygchen
added a commit
to jimmygchen/lighthouse
that referenced
this pull request
Oct 13, 2025
commit bf10815 Author: Jimmy Chen <[email protected]> Date: Fri Oct 10 11:30:45 2025 +1100 Fix tests and add some tests. commit cb59682 Author: Jimmy Chen <[email protected]> Date: Fri Oct 10 00:41:17 2025 +1100 Fix duplicate fields being logged when the field exists in both the span and the event. Prefer event fields when this happens.
jchavarri
pushed a commit
to jchavarri/lighthouse
that referenced
this pull request
Oct 21, 2025
…pan and the event (sigp#8183) Closes sigp#7995. Fix duplicate fields being logged when the field exists in both the span and the event. Prefer event fields when this happens. ``` Sep 15 08:13:46.339 WARN State cache missed state_root: 0xc34826ff7794de63a553832b7aff13572d1c716b9e03d5ef7b29649adf98abe2, block_root: 0xf16d3f5b4cc6ec876b7faeccd9f2d4102dc56ed32e828754b62601637910ec1f, state_root: 0xc34826ff7794de63a553832b7aff13572d1c716b9e03d5ef7b29649adf98abe2, block_root: 0xf16d3f5b4cc6ec876b7faeccd9f2d4102dc56ed32e828754b62601637910ec1f ``` becomes ``` Sep 15 08:13:46.339 WARN State cache missed state_root: 0xc34826ff7794de63a553832b7aff13572d1c716b9e03d5ef7b29649adf98abe2, block_root: 0xf16d3f5b4cc6ec876b7faeccd9f2d4102dc56ed32e828754b62601637910ec1f ``` Co-Authored-By: Jimmy Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Closes #7995.
Fix duplicate fields being logged when the field exists in both the span and the event. Prefer event fields when this happens.
becomes