-
Notifications
You must be signed in to change notification settings - Fork 957
Bump kzg library versions #8174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jimmygchen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
| # Turn off c-kzg's default features which include `blst/portable`. We can turn on blst's portable | ||
| # feature ourselves when desired. | ||
| c-kzg = { version = "2.1.0", default-features = false } | ||
| c-kzg = { version = "2.1", default-features = false } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't actually do anything btw, a 2.1.0 requirement is identical to a 2.1.
Both allow versions >= 2.1.0 && < 3.0.0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense. I just thought it was confusing to have the explicit patch version in the Cargo.toml (2.1.0) but having a higher patch version in the lockfile (2.1.5).
N/A Update c-kzg and rust-eth-kzg to their latest versions. Also removes the patch version hardcoding in Cargo.toml. Co-Authored-By: Pawan Dhananjay <[email protected]>
Issue Addressed
N/A
Proposed Changes
Update c-kzg and rust-eth-kzg to their latest versions. Also removes the patch version hardcoding in Cargo.toml.