Skip to content

Conversation

@pawanjay176
Copy link
Member

Issue Addressed

N/A

Proposed Changes

Update c-kzg and rust-eth-kzg to their latest versions. Also removes the patch version hardcoding in Cargo.toml.

@pawanjay176 pawanjay176 added ready-for-review The code is ready for review v8.0.0 Q4 2025 Fusaka Mainnet Release labels Oct 8, 2025
Copy link
Member

@jimmygchen jimmygchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jimmygchen jimmygchen added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Oct 9, 2025
@mergify mergify bot added the queued label Oct 9, 2025
mergify bot added a commit that referenced this pull request Oct 9, 2025
@mergify mergify bot merged commit 8e382ce into sigp:unstable Oct 9, 2025
37 checks passed
@mergify mergify bot removed the queued label Oct 9, 2025
# Turn off c-kzg's default features which include `blst/portable`. We can turn on blst's portable
# feature ourselves when desired.
c-kzg = { version = "2.1.0", default-features = false }
c-kzg = { version = "2.1", default-features = false }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't actually do anything btw, a 2.1.0 requirement is identical to a 2.1.

Both allow versions >= 2.1.0 && < 3.0.0.

https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#default-requirements

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. I just thought it was confusing to have the explicit patch version in the Cargo.toml (2.1.0) but having a higher patch version in the lockfile (2.1.5).

jchavarri pushed a commit to jchavarri/lighthouse that referenced this pull request Oct 21, 2025
N/A


  Update c-kzg and rust-eth-kzg to their latest versions. Also removes the patch version hardcoding in Cargo.toml.


Co-Authored-By: Pawan Dhananjay <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-merge This PR is ready to merge. v8.0.0 Q4 2025 Fusaka Mainnet Release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants