Skip to content

Quote BeaconState::proposer_lookahead in JSON repr #8167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mergify merged 1 commit into from
Oct 8, 2025
Merged

Quote BeaconState::proposer_lookahead in JSON repr #8167

mergify merged 1 commit into from
Oct 8, 2025

Conversation

@michaelsproul
Copy link
Member

@michaelsproul michaelsproul commented Oct 7, 2025

Proposed Changes

Use quoted integers for state.proposer_lookahead when serializing JSON. This is standard for all integer fields, but was missed for the newly added proposer lookahead. I noticed this issue while inspecting the head state on a local devnet.

I'm glad we found this before someone reported it :P

@michaelsproul michaelsproul added bug Something isn't working ready-for-review The code is ready for review low-hanging-fruit Easy to resolve, get it before someone else does! HTTP-API fulu Required for the upcoming Fulu hard fork v8.0.0 Q4 2025 Fusaka Mainnet Release labels Oct 7, 2025
eserilev
eserilev approved these changes Oct 7, 2025
View reviewed changes
Copy link
Member

@eserilev eserilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch!

@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Oct 7, 2025
@mergify mergify bot added the queued label Oct 7, 2025
mergify bot added a commit that referenced this pull request Oct 7, 2025
@mergify
Merge of #8167
053ad58
@mergify mergify bot mentioned this pull request Oct 7, 2025
Closed
6 tasks
@mergify mergify bot merged commit b5c2a96 into sigp:unstable Oct 8, 2025
37 checks passed
@mergify mergify bot removed the queued label Oct 8, 2025
@michaelsproul michaelsproul deleted the fix-proposer-lookahead-json branch October 8, 2025 00:26
jchavarri pushed a commit to jchavarri/lighthouse that referenced this pull request Oct 21, 2025
@michaelsproul @jchavarri
Quote BeaconState::proposer_lookahead in JSON repr (sigp#8167)
8e93f0b 
Use quoted integers for `state.proposer_lookahead` when serializing JSON. This is standard for all integer fields, but was missed for the newly added proposer lookahead. I noticed this issue while inspecting the head state on a local devnet.

I'm glad we found this before someone reported it :P


Co-Authored-By: Michael Sproul <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eserilev eserilev eserilev approved these changes

Assignees

No one assigned

Labels

bug Something isn't working fulu Required for the upcoming Fulu hard fork HTTP-API low-hanging-fruit Easy to resolve, get it before someone else does! ready-for-merge This PR is ready to merge. v8.0.0 Q4 2025 Fusaka Mainnet Release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@michaelsproul @eserilev