Skip to content

Improve spec compliance for /eth/v1/config/spec API #8144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mergify merged 1 commit into from
Oct 1, 2025
Merged

Improve spec compliance for /eth/v1/config/spec API #8144

mergify merged 1 commit into from
Oct 1, 2025

Conversation

@michaelsproul
Copy link
Member

@michaelsproul michaelsproul commented Oct 1, 2025

Proposed Changes

  • Remove the unnecessary _MILLIS suffix from MAXIMUM_GOSSIP_CLOCK_DISPARITY
  • Add missing Deneb preset KZG_COMMITMENT_INCLUSION_PROOF_DEPTH, not to be confused with KZG_COMMITMENTS_INCLUSION_PROOF_DEPTH (plural) from Fulu...

@michaelsproul michaelsproul added ready-for-review The code is ready for review low-hanging-fruit Easy to resolve, get it before someone else does! HTTP-API labels Oct 1, 2025
jimmygchen
jimmygchen approved these changes Oct 1, 2025
View reviewed changes
Copy link
Member

@jimmygchen jimmygchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for the fix!

@jimmygchen jimmygchen added the v8.0.0 Q4 2025 Fusaka Mainnet Release label Oct 1, 2025
@mergify
Copy link

mergify bot commented Oct 1, 2025

Some required checks have failed. Could you please take a look @michaelsproul? 🙏

@mergify mergify bot added waiting-on-author The reviewer has suggested changes and awaits thier implementation. ready-for-review The code is ready for review and removed ready-for-review The code is ready for review waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Oct 1, 2025
@jimmygchen jimmygchen added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Oct 1, 2025
@mergify mergify bot added the queued label Oct 1, 2025
mergify bot added a commit that referenced this pull request Oct 1, 2025
@mergify
Merge of #8144
f19b88e
@mergify mergify bot mentioned this pull request Oct 1, 2025
Closed
6 tasks
@mergify mergify bot merged commit 26575c5 into sigp:unstable Oct 1, 2025
46 of 47 checks passed
@mergify mergify bot removed the queued label Oct 1, 2025
jchavarri pushed a commit to jchavarri/lighthouse that referenced this pull request Oct 21, 2025
@michaelsproul @jchavarri
Improve spec compliance for /eth/v1/config/spec API (sigp#8144)
8212561 
- [x] Remove the unnecessary `_MILLIS` suffix from `MAXIMUM_GOSSIP_CLOCK_DISPARITY`
- [x] Add missing Deneb preset `KZG_COMMITMENT_INCLUSION_PROOF_DEPTH`, not to be confused with `KZG_COMMITMENTS_INCLUSION_PROOF_DEPTH` (plural) from Fulu...


Co-Authored-By: Michael Sproul <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jimmygchen jimmygchen jimmygchen approved these changes

Assignees

No one assigned

Labels

HTTP-API low-hanging-fruit Easy to resolve, get it before someone else does! ready-for-merge This PR is ready to merge. v8.0.0 Q4 2025 Fusaka Mainnet Release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@michaelsproul @jimmygchen