Make the block cache optional #8066
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelsproul
added
optimization
michaelsproul
commented
Sep 18, 2025
jimmygchen
added
the
waiting-on-author
michaelsproul
added
ready-for-review
Member
Author
|
Fixed the tests, there was just a small issue with us not deleting from the state cache when the block cache was disabled. The fix is to always delete from the state cache, I don't think this should impose too much overhead 🙏 But re-testing with a backfilling supernode should confirm this. |
jimmygchen
approved these changes
Sep 18, 2025
Member
jimmygchen
left a comment
jimmygchen
left a comment
There was a problem hiding this comment.
Looks good!
Tested this earlier and this fixes the slow persist_block_and_blobs and rpc serving behaviour 🎉
jimmygchen
added
ready-for-merge
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Address contention on the store's
block_cacheby allowing it to be disabled when--block-cache-size 0is provided, and also making this the default.Additional Info
It would also be good to add a metric on
block_cache.lock(), but I think this would require abstracting/copying some of theCanonicalHeadRwLockstuff and I haven't done that yet.