Add missing event in PendingComponent span and clean up sync logs
#8033
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmygchen
added
ready-for-review
jimmygchen
commented
Sep 12, 2025
| target_head_slot = %target_head_slot, | ||
| target_head_root = %target_head_root, | ||
| chain_type = %chain_type, | ||
| ) |
Member
Author
There was a problem hiding this comment.
skip all and explicitly add fields to use Display for some fields and exclude peer_id
Member
There was a problem hiding this comment.
So from my understanding this skip_all will skip all fields except explicitly states in the fields(), so it will skip the tracing for peers: HashSet<PeerId> as described in the PR
Member
Author
There was a problem hiding this comment.
yep that's right! and there's always a single peer when creating a lookup, and its often very misleading because new peers can get added to the lookup later, we'd then log incorrect peers when sending out requests.
jimmygchen
commented
Sep 12, 2025
| /// Whether this batch contains all blocks or all blocks and blobs. | ||
| batch_type: ByRangeRequestType, | ||
| /// Pin the generic | ||
| #[derivative(Debug = "ignore")] |
Member
Author
There was a problem hiding this comment.
the debug impl of PhantomData is very noisy and not really helpful in this case
jimmygchen
commented
Sep 12, 2025
| status = pending_components.status_str(num_expected_columns_opt), | ||
| "Component added to data availability checker" | ||
| ); | ||
| }); |
Member
Author
There was a problem hiding this comment.
log this under the span to make sure the debug event is included in the trace/span
|
Some required checks have failed. Could you please take a look @jimmygchen? 🙏 |
mergify
bot
added
waiting-on-author
jimmygchen
added
ready-for-review
chong-he
approved these changes
Sep 12, 2025
Member
chong-he
left a comment
chong-he
left a comment
There was a problem hiding this comment.
Nice. I like the replacement of skip(xx) with skip_all and only specify the fields we want to include, making it easier to maintain and more future proof.
| target_head_slot = %target_head_slot, | ||
| target_head_root = %target_head_root, | ||
| chain_type = %chain_type, | ||
| ) |
Member
There was a problem hiding this comment.
So from my understanding this skip_all will skip all fields except explicitly states in the fields(), so it will skip the tracing for peers: HashSet<PeerId> as described in the PR
jimmygchen
added
ready-for-merge
6 tasks
PoulavBhowmick03
pushed a commit
to PoulavBhowmick03/lighthouse
that referenced
this pull request
Sep 12, 2025
…igp#8033) I was looking into some long `PendingComponents` span and noticed the block event wasn't added to the span, so it wasn't possible to see when the block was added from the trace view, this PR fixes this. <img width="637" height="430" alt="image" src="https://github.com/user-attachments/assets/65040b1c-11e7-43ac-951b-bdfb34b665fb" /> Additionally I've noticed a lot of noises and confusion in sync logs due to the initial`peer_id` being included as part of the syncing chain span, causing all logs under the span to have that `peer_id`, which may not be accurate for some sync logs, I've removed `peer_id` from the `SyncingChain` span, and also cleaned up a bunch of spans to use `%` (display) for slots and epochs to make logs easier to read. Co-Authored-By: Jimmy Chen <[email protected]>
kevaundray
pushed a commit
to kevaundray/lighthouse
that referenced
this pull request
Sep 13, 2025
…igp#8033) I was looking into some long `PendingComponents` span and noticed the block event wasn't added to the span, so it wasn't possible to see when the block was added from the trace view, this PR fixes this. <img width="637" height="430" alt="image" src="https://github.com/user-attachments/assets/65040b1c-11e7-43ac-951b-bdfb34b665fb" /> Additionally I've noticed a lot of noises and confusion in sync logs due to the initial`peer_id` being included as part of the syncing chain span, causing all logs under the span to have that `peer_id`, which may not be accurate for some sync logs, I've removed `peer_id` from the `SyncingChain` span, and also cleaned up a bunch of spans to use `%` (display) for slots and epochs to make logs easier to read. Co-Authored-By: Jimmy Chen <[email protected]>
jtraglia
pushed a commit
to jtraglia/lighthouse
that referenced
this pull request
Sep 16, 2025
…igp#8033) I was looking into some long `PendingComponents` span and noticed the block event wasn't added to the span, so it wasn't possible to see when the block was added from the trace view, this PR fixes this. <img width="637" height="430" alt="image" src="https://github.com/user-attachments/assets/65040b1c-11e7-43ac-951b-bdfb34b665fb" /> Additionally I've noticed a lot of noises and confusion in sync logs due to the initial`peer_id` being included as part of the syncing chain span, causing all logs under the span to have that `peer_id`, which may not be accurate for some sync logs, I've removed `peer_id` from the `SyncingChain` span, and also cleaned up a bunch of spans to use `%` (display) for slots and epochs to make logs easier to read. Co-Authored-By: Jimmy Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
I was looking into some long
PendingComponentsspan and noticed the block event wasn't added to the span, so it wasn't possible to see when the block was added from the trace view, this PR fixes this.Additionally I've noticed a lot of noises and confusion in sync logs due to the initial
peer_idbeing included as part of the syncing chain span, causing all logs under the span to have thatpeer_id, which may not be accurate for some sync logs, I've removedpeer_idfrom theSyncingChainspan, and also cleaned up a bunch of spans to use%(display) for slots and epochs to make logs easier to read.