Fixed orphaned verify_cell_proof_chunk span.
#8026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmygchen
added
ready-for-review
|
Some required checks have failed. Could you please take a look @jimmygchen? 🙏 |
mergify
bot
added
waiting-on-author
eserilev
approved these changes
Sep 10, 2025
jimmygchen
added
ready-for-merge
|
This pull request has been removed from the queue for the following reason: The merge conditions cannot be satisfied due to failing checks: You may have to fix your CI before adding the pull request to the queue again. |
PoulavBhowmick03
pushed a commit
to PoulavBhowmick03/lighthouse
that referenced
this pull request
Sep 12, 2025
Fixed orphaned kzg verify cell proof chunk spans. See screenshot: <img width="1898" height="574" alt="image" src="https://github.com/user-attachments/assets/d60d8768-f995-407d-b7af-59722429e175" /> The parent span needs to be passed explicitly to the chunk verification span as parent, as rayon runs the function in a separate thread. Co-Authored-By: Jimmy Chen <[email protected]> Co-Authored-By: Eitan Seri-Levi <[email protected]>
kevaundray
pushed a commit
to kevaundray/lighthouse
that referenced
this pull request
Sep 13, 2025
Fixed orphaned kzg verify cell proof chunk spans. See screenshot: <img width="1898" height="574" alt="image" src="https://github.com/user-attachments/assets/d60d8768-f995-407d-b7af-59722429e175" /> The parent span needs to be passed explicitly to the chunk verification span as parent, as rayon runs the function in a separate thread. Co-Authored-By: Jimmy Chen <[email protected]> Co-Authored-By: Eitan Seri-Levi <[email protected]>
jtraglia
pushed a commit
to jtraglia/lighthouse
that referenced
this pull request
Sep 16, 2025
Fixed orphaned kzg verify cell proof chunk spans. See screenshot: <img width="1898" height="574" alt="image" src="https://github.com/user-attachments/assets/d60d8768-f995-407d-b7af-59722429e175" /> The parent span needs to be passed explicitly to the chunk verification span as parent, as rayon runs the function in a separate thread. Co-Authored-By: Jimmy Chen <[email protected]> Co-Authored-By: Eitan Seri-Levi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Fixed orphaned kzg verify cell proof chunk spans. See screenshot:
The parent span needs to be passed explicitly to the chunk verification span as parent, as rayon runs the function in a separate thread.