Instrument tracing on block production code path #8017
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmygchen
force-pushed
the
block-production-tracing
branch
from
86ae2b8 to
093d4b6
Compare
jimmygchen
force-pushed
the
block-production-tracing
branch
from
093d4b6 to
664f18f
Compare
michaelsproul
approved these changes
Sep 10, 2025
Member
michaelsproul
left a comment
michaelsproul
left a comment
There was a problem hiding this comment.
LGTM, and the example span looks nice 👌
michaelsproul
added
ready-for-merge
4 tasks
PoulavBhowmick03
pushed a commit
to PoulavBhowmick03/lighthouse
that referenced
this pull request
Sep 12, 2025
Partially sigp#7814. Instrument block production code path. New root spans: * `produce_block_v3` * `produce_block_v2` Example traces: <img width="518" height="432" alt="image" src="https://github.com/user-attachments/assets/a9413d25-501c-49dc-95cc-623db5988981" /> Co-Authored-By: Jimmy Chen <[email protected]>
kevaundray
pushed a commit
to kevaundray/lighthouse
that referenced
this pull request
Sep 13, 2025
Partially sigp#7814. Instrument block production code path. New root spans: * `produce_block_v3` * `produce_block_v2` Example traces: <img width="518" height="432" alt="image" src="https://github.com/user-attachments/assets/a9413d25-501c-49dc-95cc-623db5988981" /> Co-Authored-By: Jimmy Chen <[email protected]>
jtraglia
pushed a commit
to jtraglia/lighthouse
that referenced
this pull request
Sep 16, 2025
Partially sigp#7814. Instrument block production code path. New root spans: * `produce_block_v3` * `produce_block_v2` Example traces: <img width="518" height="432" alt="image" src="https://github.com/user-attachments/assets/a9413d25-501c-49dc-95cc-623db5988981" /> Co-Authored-By: Jimmy Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Partially #7814. Instrument block production code path.
New root spans:
produce_block_v3produce_block_v2Example traces: