Remove unused logging metrics #7997
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelsproul
added
ready-for-review
|
Some required checks have failed. Could you please take a look @michaelsproul? 🙏 |
mergify
bot
added
waiting-on-author
chong-he
reviewed
Sep 8, 2025
Member
chong-he
left a comment
chong-he
left a comment
There was a problem hiding this comment.
Looks good, just need to delete the dependencies input here:
lighthouse/common/logging/src/lib.rs
Lines 1 to 2 in fd10b63
michaelsproul
added
ready-for-review
jimmygchen
approved these changes
Sep 12, 2025
jimmygchen
added
ready-for-merge
6 tasks
PoulavBhowmick03
pushed a commit
to PoulavBhowmick03/lighthouse
that referenced
this pull request
Sep 12, 2025
@chong-he noticed that the INFO/WARN/ERRO log counts on our dashboards had stopped working. Since switching to `tracing` we are now tracking total events _per crate_, and the global counters are unused. Per-crate metrics are here: https://github.com/sigp/lighthouse/blob/cfb1f7331064b758c6786e4e1dc15507af5ff5d1/common/logging/src/tracing_metrics_layer.rs#L61-L63 Delete the unused global counters from the source. We can sum across the per-crate metric in our dashboards to restore the previous functionality. Co-Authored-By: Michael Sproul <[email protected]>
kevaundray
pushed a commit
to kevaundray/lighthouse
that referenced
this pull request
Sep 13, 2025
@chong-he noticed that the INFO/WARN/ERRO log counts on our dashboards had stopped working. Since switching to `tracing` we are now tracking total events _per crate_, and the global counters are unused. Per-crate metrics are here: https://github.com/sigp/lighthouse/blob/cfb1f7331064b758c6786e4e1dc15507af5ff5d1/common/logging/src/tracing_metrics_layer.rs#L61-L63 Delete the unused global counters from the source. We can sum across the per-crate metric in our dashboards to restore the previous functionality. Co-Authored-By: Michael Sproul <[email protected]>
jtraglia
pushed a commit
to jtraglia/lighthouse
that referenced
this pull request
Sep 16, 2025
@chong-he noticed that the INFO/WARN/ERRO log counts on our dashboards had stopped working. Since switching to `tracing` we are now tracking total events _per crate_, and the global counters are unused. Per-crate metrics are here: https://github.com/sigp/lighthouse/blob/cfb1f7331064b758c6786e4e1dc15507af5ff5d1/common/logging/src/tracing_metrics_layer.rs#L61-L63 Delete the unused global counters from the source. We can sum across the per-crate metric in our dashboards to restore the previous functionality. Co-Authored-By: Michael Sproul <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
@chong-he noticed that the INFO/WARN/ERRO log counts on our dashboards had stopped working. Since switching to
tracingwe are now tracking total events per crate, and the global counters are unused.Per-crate metrics are here:
lighthouse/common/logging/src/tracing_metrics_layer.rs
Lines 61 to 63 in cfb1f73
Proposed Changes
Delete the unused global counters from the source.
We can sum across the per-crate metric in our dashboards to restore the previous functionality.