Skip to content

Conversation

@jimmygchen
Copy link
Member

Issue Addressed

The http-api tests job incorrectly runs the beacon_chain tests due to an copy paste error in the Makefile.

@jimmygchen jimmygchen added ready-for-review The code is ready for review low-hanging-fruit Easy to resolve, get it before someone else does! labels Jul 29, 2025
@mergify
Copy link

mergify bot commented Jul 29, 2025

Some required checks have failed. Could you please take a look @jimmygchen? 🙏

@mergify mergify bot added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Jul 29, 2025
@jimmygchen
Copy link
Member Author

Looks like we got throttled on github runners, will re-run the workflow later.

@jimmygchen jimmygchen requested a review from chong-he July 29, 2025 08:09
@chong-he
Copy link
Member

@michaelsproul
Copy link
Member

A lot of the builder-related tests are broken, I think since the change we made to not blind local blocks.

I think we need to update the tests to actually use the mock_builder so that we don't error at the publication step.

@michaelsproul michaelsproul removed the low-hanging-fruit Easy to resolve, get it before someone else does! label Jul 31, 2025
@michaelsproul
Copy link
Member

These tests are a nightmare. The mock-builder doesn't really work for producing real blinded blocks that we can unblind, and I'm still dealing with config issues. I think I'll have to come back to this next week unless someone else wants to jump on it

@michaelsproul
Copy link
Member

I got the tests passing for Electra, but I just noticed that the node doesn't seem to actually be using the payload from the builder, the logs show:

2025-07-31T07:26:09.704725Z INFO execution_layer: Requested blinded execution payload relay_fee_recipient="0x2a2a2a2a2a2a2a2a2a2a2a2a2a2a2a2a2a2a2a2a" relay_response_ms=71
local_fee_recipient="0x2a2a2a2a2a2a2a2a2a2a2a2a2a2a2a2a2a2a2a2a" local_response_ms=7 parent_hash=0x957126b7c0f77ed65d51b20a59c42a3cbddb8612f7564c205e637420e19a4384
2025-07-31T07:26:09.704732Z INFO execution_layer: Received local and builder payloads relay_block_hash=0x9c638276377f4f0ab1100f7cd7a06ae48d56c22ad07ddd7860e6d486de8f3897 l
ocal_block_hash=0x8efa54a29595aabacc12d1c7fb5742e7545aa1588b91fe863da1c6e4d8cd2caf parent_hash=0x957126b7c0f77ed65d51b20a59c42a3cbddb8612f7564c205e637420e19a4384
2025-07-31T07:26:09.705792Z INFO execution_layer: Local block is more profitable than relay block local_value=10000000000000000 relay_value=10000000000000000 boosted_relay_value=10000000000000000 builder_boost_factor=None

Comment on lines +325 to +328
assert_eq!(
error_response.status(),
Some(StatusCode::INTERNAL_SERVER_ERROR)
);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still doesn't really work (the tests are failing), but I think for now I'm giving up on getting accurate error codes for Fulu, because it requires too much fussing around with mock_builder's warp code.

@michaelsproul
Copy link
Member

michaelsproul commented Aug 6, 2025

Current status:

  • Electra tests are partly failing, but the failures might be straightforward
  • Fulu tests are mostly failing, might require more invasive fixes

The edit-debug cycle is super slow here, which makes progress painful.

@jimmygchen jimmygchen requested a review from jxs as a code owner August 8, 2025 06:35
@jimmygchen jimmygchen force-pushed the fix-http-api-tests-ci branch from 376b38d to c8fb3c2 Compare August 8, 2025 12:41
@jimmygchen
Copy link
Member Author

broadcast_validation_tests.rs are now all passing on electra, but interactive_tests are failing 💀
will continue next week!

@michaelsproul
Copy link
Member

Closing in favour of:

Thanks Manas!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HTTP-API v8.0.0-rc.0 Q3 2025 release for Fusaka on Holesky waiting-on-author The reviewer has suggested changes and awaits thier implementation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants