-
Notifications
You must be signed in to change notification settings - Fork 958
Fix http-api tests not getting run on CI
#7809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Some required checks have failed. Could you please take a look @jimmygchen? 🙏 |
|
Looks like we got throttled on github runners, will re-run the workflow later. |
|
Looks like we need to fix the command in the |
Co-authored-by: chonghe <[email protected]>
|
A lot of the builder-related tests are broken, I think since the change we made to not blind local blocks. I think we need to update the tests to actually use the |
|
These tests are a nightmare. The mock-builder doesn't really work for producing real blinded blocks that we can unblind, and I'm still dealing with config issues. I think I'll have to come back to this next week unless someone else wants to jump on it |
|
I got the tests passing for Electra, but I just noticed that the node doesn't seem to actually be using the payload from the builder, the logs show:
|
| assert_eq!( | ||
| error_response.status(), | ||
| Some(StatusCode::INTERNAL_SERVER_ERROR) | ||
| ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This still doesn't really work (the tests are failing), but I think for now I'm giving up on getting accurate error codes for Fulu, because it requires too much fussing around with mock_builder's warp code.
|
Current status:
The edit-debug cycle is super slow here, which makes progress painful. |
376b38d to
c8fb3c2
Compare
|
|
|
Closing in favour of: Thanks Manas! |
Issue Addressed
The
http-apitests job incorrectly runs thebeacon_chaintests due to an copy paste error in theMakefile.