Increase default work queue size #7415
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelsproul
added
optimization
michaelsproul
force-pushed
the
bump-work-queue-size
branch
from
bdede4f to
a6e3a41
Compare
Member
Author
|
I forgot but we also still have the hidden flag for this, so users could crank up the queue size without a new release using this flag: |
eserilev
approved these changes
May 8, 2025
Member
eserilev
left a comment
eserilev
left a comment
There was a problem hiding this comment.
Thanks for opening this PR. Just one smol test failure, but other than that LGTM!
Member
Author
|
This change doesn't seem to have been effective in preventing the queue from filling. We might need a higher value. |
Member
Author
|
I'm inclined to close this in favour of the "proper" fix in v7.1.0: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Fix for error message seen on some nodes which are struggling slightly after Pectra:
Because we convert
SingleAttestations to regular attestations in a separate work event, we are now saturating the work event queue more often. This will remain an issue until a more optimised implementation ofSingleAttestationprocessing is merged (likely for v7.1.0). See:SingleAttestationimplementation further #6970Proposed Changes
Double the size of the generic work event queue. This isn't guaranteed to fix the issue, as nodes could be struggling to an arbitrary degree. However it should make up for the approx doubling of work events introduced by Pectra so that only nodes logging errors prior to the fork are logging errors now.
Additional Info
I'm rolling this out to some of our Holesky nodes that exhibit this behaviour and will report back on its efficacy.