feat: add tests for filtering GET /beacon/pool/attestations #7321
Conversation
|
|
macladson
left a comment
macladson
left a comment
There was a problem hiding this comment.
Hi. Just a heads up that you have based this PR on the stable branch. Active development should be on top of unstable and target the unstable branch
|
@macladson did i do good or no? |
|
@gap-editor no, need to get rid of those commits from stable |
chong-he
added
waiting-on-author
|
This pull request has merge conflicts. Could you please resolve them @gap-editor? 🙏 |
macladson
left a comment
macladson
left a comment
There was a problem hiding this comment.
Looks like there are some conflicts. Can you update your branch? (Either merge or rebase on unstable)
@macladson done. if smth is wrong may be better to reopen PR in unstable branch? |
|
All required checks have passed and there are no merge conflicts. This pull request may now be ready for another review. |
mergify
bot
added
ready-for-review
|
Some required checks have failed. Could you please take a look @gap-editor? 🙏 |
mergify
bot
added
waiting-on-author
|
Hi @gap-editor, this pull request has been closed automatically due to 30 days of inactivity. If you’d like to continue working on it, feel free to reopen at any time. |
6 participants
Added
test_get_beacon_pool_attestations_filteredto verify that the/eth/v2/beacon/pool/attestationsendpoint correctly filters attestations based on theslotandcommittee_indexquery parameters, as required by #7312.