Skip to content

Conversation

@chong-he
Copy link
Member

@chong-he chong-he commented Apr 9, 2025

@michaelsproul michaelsproul requested a review from dapplion April 9, 2025 13:13
@chong-he chong-he added electra Required for the Electra/Prague fork v7.0.0 New release c. Q1 2025 ready-for-review The code is ready for review labels Apr 9, 2025
@michaelsproul
Copy link
Member

@chong-he
Copy link
Member Author

CK do you mind copying across the changes in electra.yaml from here: https://github.com/gnosischain/specs/blob/de1d51759c8bb786c7172740c66ec50cd8cb8d1d/consensus/preset/gnosis/electra.yaml

into consensus/types/presets/gnosis?

The only difference is this first line below:

# `uint64(2**0)` (= 1)
MAX_CONSOLIDATION_REQUESTS_PER_PAYLOAD: 2

which the current LH branch looks correct?

# `uint64(2**1)` (= 2)
MAX_CONSOLIDATION_REQUESTS_PER_PAYLOAD: 2

# `uint64(2**1)` (= 2)
MAX_CONSOLIDATION_REQUESTS_PER_PAYLOAD: 2

If MAX_CONSOLIDATION_REQUESTS_PER_PAYLOAD: 2 is 2, then it should be 2**1 = 2?

@michaelsproul
Copy link
Member

@chong-he, good catch, looks like the comment in the upstream Gnosis preset is wrong then

@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Apr 10, 2025
mergify bot added a commit that referenced this pull request Apr 10, 2025
@mergify
Copy link

mergify bot commented Apr 10, 2025

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@michaelsproul
Copy link
Member

@mergify requeue

@mergify
Copy link

mergify bot commented Apr 10, 2025

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

mergify bot added a commit that referenced this pull request Apr 10, 2025
@mergify mergify bot merged commit 9370362 into sigp:release-v7.0.0 Apr 10, 2025
31 checks passed
@macladson macladson mentioned this pull request Apr 11, 2025
@chong-he chong-he deleted the gnosis-pectra-config branch May 6, 2025 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

electra Required for the Electra/Prague fork ready-for-merge This PR is ready to merge. v7.0.0 New release c. Q1 2025

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants