Skip to content

Conversation

@varun-doshi
Copy link
Contributor

Issue Addressed

Closes #7218

Proposed Changes

Add more bootnodes for Sepolia and Hoodi


# Teku
-
enr:-LK4QDwhXMitMbC8xRiNL-XGMhRyMSOnxej-zGifjv9Nm5G8EF285phTU-CAsMHRRefZimNI7eNpAluijMQP7NDC8kEMh2F0dG5ldHOIAAAAAAAABgCEZXRoMpDS8Zl_YAAJEAAIAAAAAAAAgmlkgnY0gmlwhAOIT_SJc2VjcDI1NmsxoQMoHWNL4MAvh6YpQeM2SUjhUrLIPsAVPB8nyxbmckC6KIN0Y3CCIyiDdWRwgiMo
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to run this PR, but I encountered the following error. It might be caused by an extra newline before enr:.

Unable to parse boot enr: Error { kind: SCANNER, problem: "could not find expected ':'", problem_mark: Mark { line: 18, column: 1 }, context: "while scanning a simple key", context_mark: Mark { line: 17, column: 1 } }

You can verify your changes before pushing by running the following commands 🙂 :

cargo run --release --bin lighthouse boot_node --enr-address x.x.x.x --network hoodi
cargo run --release --bin lighthouse boot_node --enr-address x.x.x.x --network sepolia

@ackintosh ackintosh added the waiting-on-author The reviewer has suggested changes and awaits thier implementation. label Mar 28, 2025
@michaelsproul
Copy link
Member

Can you please also rebase on the release-v7.0.0 branch? 🙏

@michaelsproul michaelsproul added the v7.0.0 New release c. Q1 2025 label Mar 28, 2025
@varun-doshi varun-doshi force-pushed the varun/bootnodes-add branch from 7ff9383 to 95f7fef Compare March 29, 2025 06:37
@varun-doshi varun-doshi changed the base branch from unstable to release-v7.0.0 March 29, 2025 06:38
@varun-doshi varun-doshi force-pushed the varun/bootnodes-add branch from 95f7fef to 654fc35 Compare March 29, 2025 06:43
@varun-doshi varun-doshi force-pushed the varun/bootnodes-add branch from 654fc35 to b3eac19 Compare March 29, 2025 06:45
@varun-doshi varun-doshi requested a review from ackintosh March 30, 2025 06:28
@michaelsproul
Copy link
Member

The YAML formatting was still wrong. I've pushed two commits to fix it:

@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Apr 2, 2025
@mergify mergify bot merged commit 0850bcf into sigp:release-v7.0.0 Apr 2, 2025
31 checks passed
@varun-doshi varun-doshi deleted the varun/bootnodes-add branch April 2, 2025 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-merge This PR is ready to merge. v7.0.0 New release c. Q1 2025

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants