Tracing cleanup #7168

macladson · 2025-03-18T14:54:24Z

Issue Addressed

#7153
#7146
#7147
#7148 -> Thanks to @ackintosh

Proposed Changes

This PR does the following:

Disable logging to file when using either --logfile-max-number 0 or --logfile-max-size 0. Note that disabling the log file in this way will also disable discv5 and libp2p logging.
discv5 and libp2p logging will be disabled by default unless running beacon_node or boot_node. This also should fix the VC panic we were seeing.
Removes log rotation and compression from libp2p and discv5 logs. It is now limited to 1 file and will rotate based on the value of the --logfile-max-size flag. We could potentially add flags specifically to control the size/number of these, however I felt a single log file was sufficient. Perhaps @AgeManning has opinions about this?
Removes all dependency logging and references to dep_log.
Introduces workspace filtering to file and stdout. This explicitly allows logs from members of the Lighthouse workspace, disallowing all others. It uses a proc macro which pulls the member list from cargo metadata at compile time. This might be over-engineered but my hope is that this list will not require maintenance.
Unifies file and stdout JSON format. With slog, the formats were slightly different. @ThreeHrSleep worked to maintain that format difference, to ensure there was no breaking changes. If these format differences are actually problematic we can restore it, however I felt the added complexity wasn't worth it.
General code improvements and cleanup.

Outstanding Issues

This does not fix certain debug logs related to the sync span being included in INFO logs. I suspect our spans will need to be reworked to fix this.
Trying to set --debug-level crit or logfile-debug-level crit will still fail. (Fix available) -> Remove crit as an option from the CLI entirely #7169
Logfile permission issues: Logfiles do not restrict permissions after rotation #7170 libp2p and discv5 logfiles are not created with restricted permissions #7171

ackintosh · 2025-03-20T22:45:28Z

@macladson I've filed a PR to fix missing libp2p(gossipsub) logs. macladson#4 Please have a look when you have time.

Fix missing gossipsub logs

macladson · 2025-03-21T02:09:01Z

@macladson I've filed a PR to fix missing libp2p(gossipsub) logs. macladson#4 Please have a look when you have time.

Amazing, thank you so much for noticing this! ❤️

ackintosh · 2025-03-21T08:56:31Z

Additionally, I noticed that the --logfile-debug-level option does not affect to discv5.log or libp2p.log. Currently both logs contain TRACE logs so the file size increases very quickly.

I've created macladson#5 to fix this. 🙏

michaelsproul · 2025-03-23T22:31:40Z

Removed the v7.0.0 label as we aren't releasing v7.0.0 from unstable, so it won't include tracing at all

mergify · 2025-03-23T22:31:46Z

This pull request has merge conflicts. Could you please resolve them @macladson? 🙏

AgeManning · 2025-03-24T01:48:06Z

Single log file is fine with me :)

macladson · 2025-03-24T01:59:54Z

Additionally, I noticed that the --logfile-debug-level option does not affect to discv5.log or libp2p.log. Currently both logs contain TRACE logs so the file size increases very quickly.

I wonder if defaulting to DEBUG is actually fine here, then we can use RUST_LOG to control the verbosity of the discv5 and libp2p logs? Seems to me that --logfile-debug-level info (or higher) would yield mostly empty discv5/libp2p logfiles anyway, whereas --logfile-debug-level info is perfectly sensible for beacon.log. I agree that we should not default to TRACE though

common/lighthouse_macros/Cargo.toml

jimmygchen

Hey @macladson

Thanks for the clean up and fixing up the issues! 🙏

I've added some comments, let me know your thoughts.

With the default debug-level and logfile-debug-level, I noticed a large amount of trace level logs in the discv5.log and libp2p.log files. @ackintosh has noticed this and created a fix for this (see his comment above). However, even debug level logs for these are quite huge, and libp2p and gossip log files were INFO level by default previously (different to beacon.log), because they're very noisy, and we had to use the RUST_LOG env var to enable deps debug logs. I think we might want to maintain this behaviour due to rate of file size growth and disk IO?

lighthouse/environment/src/lib.rs

common/lighthouse_macros/Cargo.toml

Cargo.toml

lighthouse/environment/src/tracing_common.rs

common/lighthouse_macros/src/lib.rs

common/lighthouse_macros/Cargo.toml

common/logging/src/tracing_libp2p_discv5_logging_layer.rs

jimmygchen · 2025-03-31T05:57:22Z

common/logging/src/tracing_libp2p_discv5_logging_layer.rs

+pub fn create_libp2p_discv5_tracing_layer(
+    base_tracing_log_path: Option<PathBuf>,
+    max_log_size: u64,
+) -> Option<Libp2pDiscv5TracingLayer> {


The API for this function can be simplified - we know base_tracing_log_path when calling this function, so this can be simplified by removing Option here and only call this function if the log path is Some.

common/logging/src/tracing_libp2p_discv5_logging_layer.rs

common/logging/src/lib.rs

lighthouse/src/main.rs

macladson · 2025-03-31T08:31:38Z

Thanks for the review, I'll fix these up soon!

However, even debug level logs for these are quite huge, and libp2p and gossip log files were INFO level by default previously (different to beacon.log), because they're very noisy, and we had to use the RUST_LOG env var to enable deps debug logs. I think we might want to maintain this behaviour due to rate of file size growth and disk IO?

I think the main thing to consider is what the most useful information in these logs is. It could be the case that INFO logs generally don't provide anything worthwhile for debugging and so we have to set RUST_LOG=debug manually after discovering some issue. Seems to me this friction could be avoided if we logged at debug in the first place. I'm not convinced the old behaviour was better but I'm also not really in a position to make this determination.

As an aside about file size growth and IO, my understanding is that database read/writes dwarf disk IO to the point where logging is pretty insignificant. And the files themselves are each limited to 10MB so there's no concern about unbounded file growth.

jimmygchen · 2025-03-31T12:33:22Z

common/logging/src/tracing_libp2p_discv5_logging_layer.rs

+    fn on_event(&self, event: &tracing::Event<'_>, _ctx: Context<S>) {
+        let meta = event.metadata();
+        let log_level = meta.level();
+        let timestamp = Local::now().format("%Y-%m-%d %H:%M:%S").to_string();


We currently use this approach Local::now().format() for formatting timestamp in 3 places in logging, and this format function seems relatively expensive - it adds up significantly given it gets called very frequently.

I did a brief profiling and it showed that ~11.44% of total CPU time is spent in chrono formatting functions, if I calculated correctly:

$ grep chrono lighthouse_2025-03-31-182111.collapsed | wc -l 1426 $ wc -l lighthouse_2025-03-31-182111.collapsed 12468 lighthouse_2025-03-31-182111.collapsed

Might be worth optimising a bit here, e.g. consider alternatives, e.g. StrftimeItems or the time crate.

Happy to create a separate issue to address this, given this PR already fixed a bunch of things and would be good to merge soon.

I made an attempt using StrftimeItems and it's showing much better results (~3.58% overhead) - although still quite high just for logging timestamps.
macladson#6

I wonder how much of that impact is due to using Utc::now vs using StrftimeItems. It would be nice if we could keep local time timestamps. From memory I believe this has been a point of feedback from users in the past

Oh yeah, I reckon most of the impact is from switching to StrftimeItems, DateTime::format seems to be the more expensive operation (The former is recommended in thechrono repo over DateTime::format for performance-critical applications). I tried using Utc::now to avoid timezone conversion to see how much improvements we can get.

IMO local timezone is useful for users (mostly consuming stdout rather than the debug files), and debug files is mostly for us - in that case I think UTC would be less confusing - but yeah don't have a strong opinion on timezone. I think it would be useful to have a summary of logging changes from tracing somewhere, e.g. default logging level change, timestamp logging, CLI flags etc

Created #7232 to address this.

jimmygchen

Hey @macladson ,

Thanks for the updates. It's looking much cleaner now!

I'm keen to merge this in soon and happy to leave the remaining comments if you prefer to address them separately, since none of them were introduced from your PR?

mergify · 2025-04-01T05:20:01Z

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

☑️ test-suite-success

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

jimmygchen · 2025-04-01T06:18:14Z

@mergify dequeue

mergify · 2025-04-01T06:18:25Z

This pull request has been removed from the queue for the following reason: pull request dequeued.

Pull request #7168 has been dequeued by a dequeue command

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.
If you do update this pull request, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

mergify · 2025-04-01T06:18:26Z

dequeue

✅ The pull request has been removed from the queue `default`

jimmygchen · 2025-04-01T06:40:43Z

Waiting for #7235 to be merged to unstable to unblock CI.

jimmygchen · 2025-04-01T09:37:07Z

@mergify queue

mergify · 2025-04-01T09:37:18Z

queue

✅ The pull request has been merged automatically

Details

The pull request has been merged automatically at 4839ed6

Output for 7.1.0 release: ``` # Commit SHA PR Number Has backwards-incompat Label PR Title --- ------------ ----------- ------------------------------ -------------------------------------------- 1 d5a03c9 6872 False Add more range sync tests (#6872) 2 ec2fe38 - - [NO PR MATCH]: Merge remote-tracking branch 'origin/release-v7.0.0-beta.0' into unstable 3 3992d6b 6862 False Fix misc PeerDAS todos (#6862) 4 d603881 6928 False Add PeerDAS metrics to track subnets without peers (#6928) 5 431dd7c 6917 False Remove un-used batch sync error condition (#6917) 6 0055af5 6932 False Unsubscribe blob topics at Fulu fork (#6932) 7 6ab6eae - - [NO PR MATCH]: Merge remote-tracking branch 'origin/release-v7.0.0-beta.0' into unstable 8 193061f 6634 False Use RpcSend on RPC::self_limiter::ready_requests (#6634) 9 e5e43ec - - [NO PR MATCH]: Merge remote-tracking branch 'origin/release-v7.0.0' into unstable 10 b4be514 7012 False Add spamoor_blob in network_params.yaml (#7012) 11 01df433 7021 False update codeowners, to be more specific (#7021) 12 60964fc 6829 False Expose blst internals (#6829) 13 3fab6a2 6866 False Block availability data enum (#6866) 14 6e11bdd 6947 False feat: adds CLI flags to delay publishing for edge case testing on PeerDAS devnets (#6947) 15 454c7d0 7017 False Remove LC server config from HTTP API (#7017) 16 54b4150 7030 False Add test flag to override `SYNC_TOLERANCE_EPOCHS` for range sync testing (#7030) 17 cf4104a - - [NO PR MATCH]: Merge remote-tracking branch 'origin/release-v7.0.0' into unstable 18 8a77252 7034 False Cache validator registration only after successful publish (#7034) 19 1235d44 7048 False Remove `watch` (#7048) 20 3bc5f1f 7081 False Validator Registration ssz support (#7081) 21 b4e79ed - - [NO PR MATCH]: Merge remote-tracking branch 'origin/release-v7.0.0' into unstable 22 8d1abce 6915 False Bump SSZ version for larger bitfield `SmallVec` (#6915) 23 1916a2a 7020 False chore: update to rust-eth-kzg to 0.5.4 (#7020) 24 1a08e6f 7109 False Remove duplicate sync_tolerance_epochs config (#7109) 25 f23f984 7057 False switch to upstream gossipsub (#7057) 26 d60c24e 6339 True Integrate tracing (#6339) 27 a6bdc47 6991 False Log range sync download errors (#6991) 28 574b204 6680 False decouple `eth2` from `store` and `lighthouse_network` (#6680) 29 c095a0a 7130 False update gossipsub to the latest upstream revision (#7130) 30 5cda164 7137 False Log `file appender` initialization errors properly (#7137) 31 d96123b 7149 False Remove unnecessary `filter_layer` in logger builder (#7149) 32 a1b1d7a 7150 False Remove `discv5` logs from logfile output (#7150) 33 ca23765 6998 False Track request IDs in RangeBlockComponentsRequest (#6998) 34 d323699 7183 False Add missing `osaka-time` lcli param (#7183) 35 cbf1c04 - - [NO PR MATCH]: resolve merge conflicts between untstable and release-v7.0.0 36 2f37bf4 - - [NO PR MATCH]: Fix more merge conflicts between unstable and release-v7.0.0 37 3f6c11d 6995 False Some updates to Lighthouse book (#6995) 38 9dce729 7182 False Ensure sqlite and rusqlite are optional in `consensus/types` (#7182) 39 6f31d44 7033 False Remove CGC from data_availability checker (#7033) 40 ca8eaea 7169 True Remove `crit` as an option from the CLI entirely (#7169) 41 bde0f1e - - [NO PR MATCH]: Merge remote-tracking branch 'origin/release-v7.0.0' into unstable 42 fb7ec0d 7112 False Change `genesis-state-url-timeout` (#7112) 43 4839ed6 7168 False Tracing cleanup (#7168) 44 578db67 - - [NO PR MATCH]: Merge remote-tracking branch 'origin/release-v7.0.0' into backmerge-apr-2 45 80626e5 7244 False Attempt to fix flaky network tests (#7244) 46 d6cd049 7238 False RPC RequestId Cleanup (#7238) 47 0e6da0f - - [NO PR MATCH]: Merge branch 'release-v7.0.0' into v7-backmerge 48 57abffc 7240 False Disable log color when running in non-interactive mode (#7240) 49 6a75f24 7188 False Fix the `getBlobs` metric and ensure it is recorded promptly to prevent miscounts (#7188) 50 7cc64ca 6990 False Add missing error log and remove redundant id field from lookup logs (#6990) 51 591fb7d - - [NO PR MATCH]: Merge branch 'release-v7.0.0' into backmerge-for-openssl 52 e77fb01 7265 False Remove CLI conflict for secrets-dir and datadir (#7265) 53 b5d40e3 7256 False Align logs (#7256) 54 70850fe 6744 True Drop head tracker for summaries DAG (#6744) 55 47a85cd 7269 False Bump version to v7.1.0-beta.0 (not a release) (#7269) 56 e924264 7258 False Fullnodes to publish data columns from EL `getBlobs` (#7258) 57 759b061 7117 False Offloading KZG Proof Computation from the beacon node (#7117) 58 d96b731 7192 False Fix for #6296: Deterministic RNG in peer DAS publish block tests (#7192) 59 39eb814 - - [NO PR MATCH]: Merge branch 'release-v7.0.0' into unstable 60 70f8ab9 7309 False Add riscv64 build support (#7309) 61 be68dd2 7281 False Fix wrong custody column count for lookup blocks (#7281) 62 08882c6 6996 False Fix execution engine integration tests with latest geth version (#6996) 63 476f3a5 7161 False Add `MAX_BLOBS_PER_BLOCK_FULU` config (#7161) 64 c32569a 7225 False Restore HTTP API logging and add more metrics (#7225) 65 410af7c 7279 False feat: update mainnet bootnodes (#7279) 66 80fe133 7280 False Update Lighthouse Book for Electra features (#7280) 67 9f4b0cd 7343 False Fix Kurtosis doppelganger CI (#7343) 68 e61e92b - - [NO PR MATCH]: Merge remote-tracking branch 'origin/stable' into unstable 69 5527125 7340 False Fix GitHub releases page looks bad in GitHub dark theme (#7340) 70 c13e069 7324 False Revise logging when `queue is full` (#7324) 71 1dd3704 7346 False Enable cross-compiling for riscv64 architecture (#7346) 72 402a81c 7350 False Fix Kurtosis testnet (#7350) 73 1324d3d 5923 False Delayed RPC Send Using Tokens (#5923) 74 6fad186 6747 False feat: presign for validator account (#6747) 75 2e2b0d2 7351 False Revise consolidation info in Lighthouse book (#7351) 76 63a10ea 6956 True Changing `boot_enr.yaml` to expect `bootstap_nodes.yaml` for pectra devnet (#6956) 77 34a6c3a 6897 True vc: increase default gas limit (#6897) 78 94ccd76 6653 False Add documentation for VC API `/lighthouse/beacon/health` (#6653) 79 9779b4b 7326 False Optimize `validate_data_columns` (#7326) 80 93ec9df 7304 False Compute proposer shuffling only once in gossip verification (#7304) 81 2aa5d5c 7359 False Make sure to log SyncingChain ID (#7359) 82 c8224c8 7387 False docs: fix broken link to voluntary exit guide (#7387) 83 43c38a6 7378 False Change slog to tracing in comments (#7378) 84 beb0ce6 6922 False Make range sync peer loadbalancing PeerDAS-friendly (#6922) 85 3d92e36 6705 False Modularize validator store (#6705) 86 058dae0 7405 False Add requires --http when using vc subcommands --http-port (#7405) 87 0f13029 7409 False Don't publish data columns reconstructed from RPC columns to the gossip network (#7409) 88 8dc3d23 7400 False Add a default timeout to all `BeaconNodeHttpClient` requests (#7400) 89 e90fcbe 7416 False Add ARM binary for macOS in release (#7416) 90 4b9c16f 7199 False Add Electra forks to basic sim tests (#7199) 91 a497ec6 6975 False Retry custody requests after peer metadata updates (#6975) 92 e0c1f27 7394 False simulator: Persist beacon logs (#7394) 93 92391cd 7284 False update gossipsub to the latest upstream revision (#7284) 94 5933901 7399 False `peerdas-devnet-7`: update `DataColumnSidecarsByRoot` request to use `DataColumnsByRootIdentifier` (#7399) 95 5b25a48 7404 False Siren installation improvement (#7404) 96 e051c7c 7396 False Siren Pectra Feature Updates (#7396) 97 0a91798 7370 False impl test random for some types (#7370) 98 807848b 7443 False Next sync committee branch bug (#7443) 99 851ee2b 7454 False Extract get_domain for VoluntaryExit (#7454) 100 c2c7fb8 7460 False Make DAG construction more permissive (#7460) 101 b1138c2 7451 False Add additional mergify rules to automate triaging (#7451) 102 cc6ae9d 7463 False Fix mergify infinite loop. (#7463) 103 1853d83 7458 False Added E::slots_per_epoch() to deneb time calculation (#7458) 104 c4182e3 7433 False simulator: Write dependency logs to separate files (#7433) 105 e0ee148 7470 False Prevent mergify from updating labels while CI is still running. (#7470) 106 e21198c 7472 False One more attempt to fix mergify condition. (#7472) 107 268809a 7471 False Rust clippy 1.87 lint fixes (#7471) 108 b051a5d 7469 False Delete `at-most` in `lighthouse vm create` (#7469) 109 1d27855 7369 False impl from hash256 for `ExecutionBlockHash` (#7369) 110 23ad833 7417 False Change default EngineState to online (#7417) 111 fcfcbf9 7481 False Update mdlint to disable descriptive-link-text (#7481) 112 7684d1f 7372 False ContextDeserialize and Beacon API Improvements (#7372) 113 5393d33 7411 False Silence `Uninitialized` warn log on start-up (#7411) 114 1e6cdeb 6799 False feat: Add docker reproducible builds (#6799) 115 50dbfdf 7455 False Some updates to Lighthouse book (#7455) 116 af87135 7484 False Move MD059 rule to configuration file (#7484) 117 805c2dc 5047 False Correct reward denominator in op pool (#5047) 118 7e2df6b 7474 False Empty list `[]` to return all validators balances (#7474) 119 f06d1d0 7495 False Fix blob download from checkpointz servers (#7495) 120 0688932 7497 False Pass blobs into `ValidatorStore::sign_block` (#7497) 121 e29b607 7427 False Move notifier and latency service to `validator_services` (#7427) 122 7759cb8 7494 False Update mergify rule to not evaluate PRs that are not ready for review - to reduce noise and avoid updating stale PRs. (#7494) 123 2e96e97 7507 False Use slice.is_sorted now that it's stable (#7507) 124 a8035d7 7506 False Enable stdout logging in rpc_tests (#7506) 125 817f14c 7500 False Send execution_requests in fulu (#7500) 126 537fc5b 7459 False Revive network-test logs files in CI (#7459) 127 cf0f959 7180 False Improve log readability during rpc_tests (#7180) 128 ce8d081 7246 False Ensure logfile permissions are maintained after rotation (#7246) 129 6af8c18 7052 False Publish EL Info in Metrics (#7052) 130 a2797d4 7512 False Fix formatting errors from cargo-sort (#7512) 131 f01dc55 7505 False Update `engine_getBlobsV2` response type and add `getBlobsV2` tests (#7505) 132 e6ef644 7493 False Verify `getBlobsV2` response and avoid reprocessing imported data columns (#7493) 133 7c89b97 7382 False Handle attestation validation errors (#7382) 134 8dde5bd - - [NO PR MATCH]: Update mergify rules so that I can add `waiting-on-author` on a PR that's passing CI. Remove noisy comments. 135 8989ef8 7025 False Enable arithmetic lint in rate-limiter (#7025) 136 b7fc034 - - [NO PR MATCH]: Fix condition 137 9e9c51b - - [NO PR MATCH]: Remove redundant `and` 138 999b045 - - [NO PR MATCH]: Merge pull request #7525 from jimmygchen/mergify-again 139 0ddf9a9 7332 False Remove support for database migrations prior to schema version v22 (#7332) 140 5cda6a6 7522 False Mitigate flakiness in test_delayed_rpc_response (#7522) 141 4d21846 7533 False Prevent `AvailabilityCheckError` when there's no new custody columns to import (#7533) 142 39744df 7393 False simulator: Fix `Failed to initialize dependency logging` (#7393) 143 38a5f33 7529 False Add `console-subscriber` feature for debugging (#7529) 144 886ceb7 6882 False Run Assertoor tests in CI (#6882) 145 94a1446 7541 False Fix unexpected blob error and duplicate import in fetch blobs (#7541) 146 ae30480 7521 False Implement EIP-7892 BPO hardforks (#7521) 147 f67068e 7518 False Update `staking-deposit-cli` to `ethstaker-deposit-cli` (#7518) 148 cd83d8d 7544 False Add a name to the Tokio task (#7544) 149 357a8cc 7549 False Checkpoint sync without the blobs from Fulu (#7549) 150 2d9fc34 7540 False Fulu EF tests v1.6.0-alpha.0 (#7540) 151 dcee76c 7548 False Update key generation in validator manager (#7548) 152 9a49720 7530 False Add e2e sync tests to CI (#7530) 153 d457cee 7118 False Don't create child lookup if parent is faulty (#7118) 154 2f807e2 7538 False Add support for nightly tests (#7538) 155 e098f66 7570 False Update kurtosis config and EL images (#7570) 156 b2e8b67 7566 False Reduce number of basic sim test nodes from 7 to 4 (#7566) 157 170cd0f 7579 False Store the libp2p/discv5 logs when stopping local-testnet (#7579) 158 b08d49c 7559 False Changes for `fusaka-devnet-1` (#7559) 159 8c6abc0 7574 False Optimise parallelism in compute cells operations by zipping first (#7574) 160 7416d06 7561 False Add genesis sync test to CI (#7561) 161 076a1c3 7587 False Data column sidecar event (#7587) 162 5f208bb 7578 True Implement basic validator custody framework (no backfill) (#7578) 163 9803d69 7590 False Implement status v2 version (#7590) 164 5472cb8 7582 False Batch verify KZG proofs for getBlobsV2 (#7582) 165 a65f782 7594 False Drop stale registrations without reducing CGC (#7594) 166 ccd99c1 7588 False Wait before column reconstruction (#7588) 167 dc5f5af 7595 False Fix flaky test_rpc_block_reprocessing (#7595) 168 4fc0665 7592 False Add more context to Late Block Re-orgs (#7592) 169 6135f41 7591 False Add data columns sidecars debug beacon API (#7591) 170 3d2d65b 7593 False Advertise `--advertise-false-custody-group-count` for testing PeerDAS (#7593) 171 6786b9d 7444 True Single attestation "Full" implementation (#7444) 172 dd98534 6750 True Hierarchical state diffs in hot DB (#6750) 173 f67084a 7437 False Remove reprocess channel (#7437) 174 d509246 7620 False Remove instrumenting log level (#7620) 175 11bcccb 7133 True Remove all prod eth1 related code (#7133) 176 e34a9a0 6551 False Allow the `--beacon-nodes` list to be updated at runtime (#6551) 177 3fefda6 7611 False Send byrange responses in the correct requested range (#7611) 178 cef04ee 7462 False Implement `validator_identities` Beacon API endpoint (#7462) 179 fd643c3 7632 False Un-ignore EF test for v1.6.0-alpha.1 (#7632) 180 56b2d4b 7636 False Remove instrumenting log level (#7636) 181 8e3c5d1 7644 False Rust 1.89 compiler lint fix (#7644) 182 a0a6b93 7551 False Do not compute sync selection proofs for the sync duty at the current slot (#7551) 183 9b1f3ed 7652 False Add gossip check (#7652) 184 83cad25 7657 False Fix Rust 1.88 clippy errors & execution engine tests (#7657) 185 522e00f 7656 False Fix incorrect `waker` update condition (#7656) 186 6ea5f14 7597 False feat: better error message for light_client/bootstrap endpoint (#7597) 187 2d759f7 6576 False Fix beacon_chain metrics descriptions (#6576) 188 6be646c 7666 True Bump DB schema to v25 (#7666) 189 e45ba84 7673 False Increase http client default timeout to 2s in `http-api` tests. (#7673) 190 25ea8a8 7667 False Add Michael as codeowner for store crate (#7667) 191 c1f94d9 7669 False Test database schema stability (#7669) 192 257d270 6612 False Add voluntary exit via validator manager (#6612) 193 e305cb1 7661 True Custody persist fix (#7661) 194 41742ce 7683 False Update `SAMPLES_PER_SLOT` to be number of custody groups instead of data columns (#7683) 195 69c9c70 7681 False Use prepare_beacon_proposer endpoint for validator custody registration (#7681) 196 fcc602a 7646 False Update fulu network configs and add `MIN_EPOCHS_FOR_DATA_COLUMN_SIDECARS_REQUESTS` (#7646) 197 a459a9a 7689 False Fix and test checkpoint sync from genesis (#7689) 198 b35854b 7692 False Record v2 beacon blocks http api metrics separately (#7692) 199 c7bb3b0 7693 False Fix lookups of the block at `oldest_block_slot` (#7693) 200 0f895f3 7695 False Bump default gas limit (#7695) 201 56485cc 7707 False Remove unneeded spans that caused debug logs to appear when level is set to `info` (#7707) 202 bd8a2a8 7023 False Gossip recently computed light client data (#7023) 203 7b2f138 - - [NO PR MATCH]: Merge remote-tracking branch 'origin/stable' into release-v7.1.0 204 8e55684 7723 False Reintroduce `--logfile` with deprecation warning (#7723) 205 8b5ccac 7663 False Error from RPC `send_response` when request doesn't exist on the active inbound requests (#7663) 206 cfb1f73 7609 False Release v7.1.0 (#7609) ``` Co-Authored-By: Jimmy Chen <[email protected]>

Cleanup

d063422

macladson added ready-for-review The code is ready for review UX-and-logs v7.0.0 New release c. Q1 2025 labels Mar 18, 2025

macladson requested a review from jimmygchen March 18, 2025 14:54

macladson changed the title ~~Cleanup~~ Tracing cleanup Mar 18, 2025

macladson added 2 commits March 19, 2025 01:55

cargo sort

ab8b8cf

cargo udeps

1c5043b

ThreeHrSleep mentioned this pull request Mar 19, 2025

Disable discv5 & libp2p file logging when running VC #7163

Closed

Fix target name for gossipsub

9d08e77

ackintosh mentioned this pull request Mar 20, 2025

Fix missing gossipsub logs macladson/lighthouse#4

Merged

Merge pull request #4 from ackintosh/tracing-cleanup-fix-gossipsub

ed693db

Fix missing gossipsub logs

michaelsproul added v7.1.0 Post-Electra release and removed v7.0.0 New release c. Q1 2025 labels Mar 23, 2025

Merge branch 'unstable' into tracing-cleanup

581c788

jimmygchen reviewed Mar 26, 2025

View reviewed changes

common/lighthouse_macros/Cargo.toml Outdated Show resolved Hide resolved

jimmygchen reviewed Mar 31, 2025

View reviewed changes

Rename macro and use EnvFilter for dep logging

6f5d316

macladson commented Mar 31, 2025

View reviewed changes

lighthouse/src/main.rs Show resolved Hide resolved

macladson added 3 commits March 31, 2025 20:46

Visibility and macro fixes

6e48dd4

Add docs and fix typo

764f0bb

Formatting

ef89437

jimmygchen reviewed Mar 31, 2025

View reviewed changes

jimmygchen mentioned this pull request Mar 31, 2025

Try different date time formatting method macladson/lighthouse#6

Closed

jimmygchen approved these changes Apr 1, 2025

View reviewed changes

jimmygchen added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Apr 1, 2025

jimmygchen mentioned this pull request Apr 1, 2025

Optimise tracing timestamp formatting to reduce logging overhead #7232

Closed

jimmygchen added ready-for-merge This PR is ready to merge. and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Apr 1, 2025

mergify bot added a commit that referenced this pull request Apr 1, 2025

Merge of #7168

c1c4b0e

mergify bot mentioned this pull request Apr 1, 2025

merge queue: embarking unstable (bde0f1e) and #7168 together #7233

Closed

6 tasks

mergify bot added a commit that referenced this pull request Apr 1, 2025

Merge of #7168

7166bca

mergify bot mentioned this pull request Apr 1, 2025

merge queue: embarking unstable (bde0f1e) and #7168 together #7236

Closed

6 tasks

jimmygchen mentioned this pull request Apr 1, 2025

Fix panic when running VC #7140

Closed

Merge branch 'unstable' into tracing-cleanup

d3278bc

mergify bot merged commit 4839ed6 into sigp:unstable Apr 1, 2025
31 checks passed

Tracing cleanup #7168

Tracing cleanup #7168

Uh oh!

Conversation

macladson commented Mar 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue Addressed

Proposed Changes

Outstanding Issues

Uh oh!

ackintosh commented Mar 20, 2025

Uh oh!

macladson commented Mar 21, 2025

Uh oh!

ackintosh commented Mar 21, 2025

Uh oh!

michaelsproul commented Mar 23, 2025

Uh oh!

mergify bot commented Mar 23, 2025

Uh oh!

AgeManning commented Mar 24, 2025

Uh oh!

macladson commented Mar 24, 2025

Uh oh!

Uh oh!

jimmygchen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jimmygchen Mar 31, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

macladson commented Mar 31, 2025

Uh oh!

jimmygchen Mar 31, 2025

Choose a reason for hiding this comment

Uh oh!

jimmygchen Mar 31, 2025

Choose a reason for hiding this comment

Uh oh!

jimmygchen Mar 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

macladson Apr 1, 2025

Choose a reason for hiding this comment

Uh oh!

jimmygchen Apr 1, 2025

Choose a reason for hiding this comment

Uh oh!

jimmygchen Apr 1, 2025

Choose a reason for hiding this comment

Uh oh!

jimmygchen left a comment

Choose a reason for hiding this comment

Uh oh!

mergify bot commented Apr 1, 2025

Uh oh!

jimmygchen commented Apr 1, 2025

Uh oh!

mergify bot commented Apr 1, 2025

Uh oh!

mergify bot commented Apr 1, 2025

✅ The pull request has been removed from the queue default

Uh oh!

jimmygchen commented Apr 1, 2025

Uh oh!

jimmygchen commented Apr 1, 2025

Uh oh!

mergify bot commented Apr 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

macladson commented Mar 18, 2025 •

edited

Loading

jimmygchen Mar 31, 2025 •

edited

Loading

✅ The pull request has been removed from the queue `default`

mergify bot commented Apr 1, 2025 •

edited

Loading