Compute roots for unfinalized by_range requests with fork-choice #7098
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ByRange` requests (sigp#7058) * Load block roots from fork choice where possible to avoid loading state from disk when serving block by range requests. * Check if the start slot is newer than finalization (`start_slot >= finalized_slot`), and use fork choice in that case.
sigp#7066) * handle bbr across finalized slot gracefully * sort deps * Michael's off-by-one corrections --------- Co-authored-by: Michael Sproul <[email protected]>
dapplion
added
ready-for-review
14 tasks
michaelsproul
added
v7.0.0-beta.clean
michaelsproul
requested changes
Apr 2, 2025
…quests-fork-choice
michaelsproul
approved these changes
Apr 7, 2025
michaelsproul
added
ready-for-merge
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Includes PRs
BlocksByRangerequests #7058Cleaner for the
release-v7.0.0branch