Skip to content

Manual compaction endpoint #7072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jimmygchen merged 4 commits into from
Mar 4, 2025
Merged

Manual compaction endpoint #7072

jimmygchen merged 4 commits into from
Mar 4, 2025

Conversation

@eserilev
Copy link
Member

@eserilev eserilev commented Mar 4, 2025

For some reason manual finalization isn't triggering compaction. I'll try investigating, but in the meantime this PR introduces an endpoint that allows users to manually trigger background compaction.

@mergify
Copy link

mergify bot commented Mar 4, 2025

This pull request has merge conflicts. Could you please resolve them @eserilev? 🙏

@eserilev eserilev changed the title manual compaction endpoint Manual compaction endpoint Mar 4, 2025
@eserilev eserilev added v7.0.0-beta.2 Second hacky Holesky rescue release ready-for-review The code is ready for review labels Mar 4, 2025
michaelsproul
michaelsproul approved these changes Mar 4, 2025
View reviewed changes
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

jimmygchen
jimmygchen approved these changes Mar 4, 2025
View reviewed changes
Copy link
Member

@jimmygchen jimmygchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jimmygchen jimmygchen merged commit 1b58597 into sigp:holesky-rescue Mar 4, 2025
24 checks passed
@michaelsproul michaelsproul mentioned this pull request Mar 5, 2025
Closed
14 tasks
@eserilev eserilev mentioned this pull request Mar 10, 2025
Merged
mergify bot pushed a commit that referenced this pull request Mar 18, 2025
@eserilev
Manual compaction endpoint backport (#7104)
ed1b768 
Backports:
- #7072

To:
- #7039

#7103 should be merged first


  This PR introduces an endpoint that allows users to manually trigger background compaction.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jimmygchen jimmygchen jimmygchen approved these changes

@michaelsproul michaelsproul michaelsproul approved these changes

Assignees

No one assigned

Labels

ready-for-review The code is ready for review v7.0.0-beta.2 Second hacky Holesky rescue release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eserilev @jimmygchen @michaelsproul