Enable Light Client server by default #6950
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
Light client dashboard metricsRoughly 1 light client data processing request per slot
Light client data computation time: 25ms
State merkle proof computation times on the order of milliseconds
No block cache misses in the last 30 days
No light client data computation failures in the last 30 days
Negligible relative increase in db store disk size over last 30 days
No visible increase in CPU/memory usage over the last 30 days
No visibile increase in read/write IO operations/Throughput
Note that on local testing I also saw negligible increases in cpu usage, IO, memory usage and disk space when running the light client vs not running the light client server |
michaelsproul
approved these changes
Feb 10, 2025
Member
michaelsproul
left a comment
michaelsproul
left a comment
There was a problem hiding this comment.
Looks great, thanks!
I've just added a WARN log so that users know to remove the old --light-client-server flag.
14 tasks
michaelsproul
added a commit
that referenced
this pull request
Feb 10, 2025
Squashed commit of the following: commit e4ede45 Author: Michael Sproul <[email protected]> Date: Mon Feb 10 11:16:40 2025 +1100 Add deprecation warning log commit 022f3f8 Author: Eitan Seri-Levi <[email protected]> Date: Fri Feb 7 14:58:03 2025 +0200 fix test commit 325e71c Author: Eitan Seri-Levi <[email protected]> Date: Fri Feb 7 14:07:11 2025 +0200 add cli changes commit 74d93f6 Author: Eitan Seri-Levi <[email protected]> Date: Fri Feb 7 13:36:37 2025 +0200 Enable Light Client server by default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate the
light-client-serverflag, enable light client server by default and introduce a new flagdisable-light-client-server