Cargo update without rust_eth_kzg
#6848
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelsproul
added
ready-for-review
michaelsproul
changed the title
rust_eth_kzg
Member
Author
|
Ok, this will need the MSRV bump. This is a bit naughty, because the alloy deps shouldn't be bumping MSRV on patch releases. |
Member
Author
|
MSRV bump is fine, but I've asked about Alloy's policy here just so we know how to handle this going forward: |
jimmygchen
reviewed
Jan 30, 2025
| @@ -1,4 +1,4 @@ | |||
| FROM rust:1.80.0-bullseye AS builder | |||
| FROM rust:1.84.0-bullseye AS builder | |||
Member
There was a problem hiding this comment.
I think we can also bump the version in lcli too?
Line 4 in 96b00ef
Member
Author
There was a problem hiding this comment.
Good catch! I thought of this and then forgot to do it 🤦♂️
jimmygchen
added
waiting-on-author
jimmygchen
reviewed
Jan 30, 2025
Member
jimmygchen
left a comment
jimmygchen
left a comment
There was a problem hiding this comment.
Looks good to me! Just added a minor comment to update lcli Dockerfile as well.
Marking this as backwards-incompat due to MSRV update.
michaelsproul
added
ready-for-review
Member
Author
|
Updated! |
jimmygchen
added
ready-for-merge
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Update cargo dependencies while keeping
rust_eth_kzgpinned to0.5.1due to the regression described in:The changes from that PR were not sufficient to actually pin the dependencies of
rust_eth_kzg, because the dependencies from the workspace Cargo.toml file were not being used anywhere. To fix this, I've added them as explicit dependencies incrypto/kzg/Cargo.toml. With this change,cargo updateno longer tries to update them.Additional Info
Replaces:
Hopefully
cargo udepsdoesn't fire due to these deps not being used directly 🙏 . From memory I think this case should be fine.