Skip to content

Cargo update #6554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
AgeManning wants to merge 5 commits into from
Closed

Cargo update #6554

AgeManning wants to merge 5 commits into from

Conversation

@AgeManning
Copy link
Member

@AgeManning AgeManning commented Oct 31, 2024

Issue Addressed

Cargo update currently breaks something. Hoping for some help to fix. See CI

@AgeManning AgeManning added the help wanted Extra attention is needed label Oct 31, 2024
@jimmygchen
Copy link
Member

jimmygchen commented Oct 31, 2024

local-testnet issues are kurtosis related, addressed in #6555
Looking into sim tests now

@jimmygchen jimmygchen added ready-for-review The code is ready for review and removed help wanted Extra attention is needed labels Oct 31, 2024
@jimmygchen
Copy link
Member

jimmygchen commented Oct 31, 2024

Sim tests and local testnet tests are all passing now! 🎉

@jimmygchen jimmygchen added the v6.0.0 New major release for hierarchical state diffs label Oct 31, 2024
@michaelsproul michaelsproul added work-in-progress PR is a work-in-progress and removed ready-for-review The code is ready for review v6.0.0 New major release for hierarchical state diffs labels Nov 1, 2024
@michaelsproul
Copy link
Member

michaelsproul commented Nov 1, 2024

Maybe we can do a targeted cargo update of the crates we need to update? Doing wholesale cargo update isn't necessary for v6.0.0, especially if it's slowing down node startup

@michaelsproul michaelsproul mentioned this pull request Nov 1, 2024
Merged
@michaelsproul michaelsproul mentioned this pull request Nov 5, 2024
Merged
This was referenced Nov 25, 2024
Merged
Closed
@michaelsproul
Copy link
Member

michaelsproul commented Nov 25, 2024

I've isolated the issue to the update of rust_eth_kzg. Opened this PR to pin it:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

do-not-merge work-in-progress PR is a work-in-progress

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AgeManning @jimmygchen @michaelsproul