-
Notifications
You must be signed in to change notification settings - Fork 958
Modularize beacon processor scheduler #6448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
eserilev
wants to merge
26
commits into
sigp:unstable
from
eserilev:generalize-beacon-processor-scheduler
Closed
Modularize beacon processor scheduler #6448
eserilev
wants to merge
26
commits into
sigp:unstable
from
eserilev:generalize-beacon-processor-scheduler
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…neralize-beacon-processor-scheduler
…neralize-beacon-processor-scheduler
|
This pull request has merge conflicts. Could you please resolve them @eserilev? 🙏 |
|
This pull request has merge conflicts. Could you please resolve them @eserilev? 🙏 |
|
Some required checks have failed. Could you please take a look @eserilev? 🙏 |
|
Hi @eserilev, this pull request has been closed automatically due to 30 days of inactivity. If you’d like to continue working on it, feel free to reopen at any time. |
mergify bot
pushed a commit
that referenced
this pull request
Jun 20, 2025
Partially #6291 This PR removes the reprocess event channel from being externally exposed. All work events are now sent through the single `BeaconProcessorSend` channel. I've introduced a new `Work::Reprocess` enum variant which we then use to schedule jobs for reprocess. I've also created a new scheduler module which will eventually house the different scheduler impls. This is all needed as an initial step to generalize the beacon processor A "full" implementation for the generalized beacon processor can be found here #6448 I'm going to try to break up the full implementation into smaller PR's so it can actually be reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
blocked
code-quality
stale
Stale PRs that have been inactive and is now outdated
waiting-on-author
The reviewer has suggested changes and awaits thier implementation.
work-in-progress
PR is a work-in-progress
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Partially #6291
Proposed Changes
This PR aims to "modularize" the beacon processor scheduler. The goal is to set up the scheduler in such a way that new scheduling algorithms can be implemented/swapped in.
For now we've decided on exposing an interface that implements the following trait
We then define a
SchedulerTypeenumEach variant is a beacon processor scheduling implementation with its own unique scheduling algorithm. Swapping between the variants can be done either at the config level, or with a small code change.
Additional Info
PrioritySchedulervariant. Other scheduling algorithms might not use all these different queues to schedule the differentWorkEvents and so these queues aren't exposed outside of thePrioritySchedulerimpl.BeaconProcessorSendchannel. I've introduced a newWork::Reprocesstype which we then use to schedule jobs for reprocess. The reprocess logic itself is very specific to thePrioritySchedulerso it seems to make more sense to give other implementations maximum flexibility.