Rename deploy_block in network config#5850
Merged
mergify[bot] merged 3 commits intosigp:unstablefrom May 29, 2024
Merged
Conversation
pawanjay176
added
ready-for-review
Member
|
@michaelsproul could use another review here before we merge just to be sure. I think this may break some testing tools, but that's probably it? |
Member
|
I reckon good to go |
michaelsproul
added
ready-for-merge
2 tasks
Member
|
Looks like
I'm thinking it might be worth to just build |
Member
|
PR to build |
Member
|
@mergify queue |
✅ The pull request has been merged automaticallyDetailsThe pull request has been merged automatically at 6daeec3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
eth-clients/holesky#104
Proposed Changes
Rename deploy_block.txt which was a Lighthouse specific config file to the agreed upon standard.
Additional Info
This shouldn't cause any backward incompatibility issues with built in network configs.
This would cause backwards incompatibility issues with older versions of lighthouse trying to load networks with just
deploy_block.txtin the testnet-dir which isn't a big deal imo.