Merged
Conversation
* update * experiment * superstruct changes * revert * superstruct changes * fix tests * indexed attestation * indexed attestation superstruct * updated TODOs
* `superstruct` Attester Fork Variants * Push a little further * Deal with Encode / Decode of AttesterSlashing * not so sure about this.. * Stop Encode/Decode Bounds from Propagating Out * Tons of Changes.. * More Conversions to AttestationRef * Add AsReference trait (#15) * Add AsReference trait * Fix some snafus * Got it Compiling! :D * Got Tests Building * Get beacon chain tests compiling --------- Co-authored-by: Michael Sproul <[email protected]>
* Upgrade `superstruct` to `0.8.0` * superstruct `AggregateAndProof`
Merge unstable into Electra attestation changes
* fix get attesting indices * better errors * fix compile * only get committee index once
* attestation related ef test fixes * delete commented out stuff
Add electra lightclient types
Avoid changing slasher schema for Electra
realbigsean
approved these changes
Jun 26, 2024
consensus/state_processing/src/per_epoch_processing/single_pass.rs
Outdated
Show resolved
Hide resolved
consensus/state_processing/src/per_epoch_processing/single_pass.rs
Outdated
Show resolved
Hide resolved
consensus/state_processing/src/per_epoch_processing/single_pass.rs
Outdated
Show resolved
Hide resolved
consensus/state_processing/src/per_epoch_processing/single_pass.rs
Outdated
Show resolved
Hide resolved
consensus/state_processing/src/per_epoch_processing/single_pass.rs
Outdated
Show resolved
Hide resolved
Member
|
Just had some of my new favorite PR comments -> This looks good to me an outstanding question is whether we want to optimize this again? #5761 (comment) |
Member
We can come back and optimize this if we think it's necessary |
Member
|
@mergify queue |
✅ The pull request has been merged automaticallyDetailsThe pull request has been merged automatically at 16b8113 |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Integrate Electra epoch processing with single-pass. This required a few tricks. I hope they're correct 🤞