Electra engine api by pawanjay176 · Pull Request #5743 · sigp/lighthouse

pawanjay176 · 2024-05-08T23:52:00Z

Issue Addressed

N/A

Proposed Changes

Implements electra engine api.

Additional Info

The spec does not handle the engine_getPayloadBodies for the new electra fields. We need to add it to the spec and implement it.
This PR currently implements it in the manner that I think it will be implemented (i.e. by extending ExecutionPayloadBodyV1 to include deposit_receipts and withdrawal_requests.
Working on getting a spec out for this.

* update * experiment * superstruct changes * revert * superstruct changes * fix tests * indexed attestation * indexed attestation superstruct * updated TODOs

* `superstruct` Attester Fork Variants * Push a little further * Deal with Encode / Decode of AttesterSlashing * not so sure about this.. * Stop Encode/Decode Bounds from Propagating Out * Tons of Changes.. * More Conversions to AttestationRef * Add AsReference trait (#15) * Add AsReference trait * Fix some snafus * Got it Compiling! :D * Got Tests Building * Get beacon chain tests compiling --------- Co-authored-by: Michael Sproul <[email protected]>

…tion_changes

* Upgrade `superstruct` to `0.8.0` * superstruct `AggregateAndProof`

…_changes

Merge unstable into Electra attestation changes

* get attesting indices electra impl * fmt * get tests to pass * fmt * fix some beacon chain tests * fmt * fix slasher test * fmt got me again * fix more tests * fix tests

…/lighthouse into block-processing-electra

Add electra lightclient types

Avoid changing slasher schema for Electra

…ectra_attestation_changes

…bigsean/lighthouse into block-processing-electra

…ghthouse into electra-epoch-proc

… into electra-engine-api

realbigsean · 2024-06-26T17:21:49Z

Is it intentional to merge epoch processing changes into this branch?

Yes since we were planning to merge it into unstable after epoch processing, re-targeted the branch to fix the diff

realbigsean · 2024-06-26T17:32:01Z

Something that's missing is the payload bodies by range changes: ethereum/execution-apis#545

This PR implements an extension of the existing V1 endpoint, what's currently spec'd is to actually add a V2 endpoint: ethereum/execution-apis#545 (comment)

There may be further discussion about whether to just extend v1 but for now we won't be able to serve blocks whose payloads we've pruned until we implement this as a v2

We could use the same ExecutionPayloadBody type for both v1 and v2 because v2 is fully backwards compatible but there will be annoying fork-switching logic we we want to query the v2 endpoint after the electra fork so we're sure the EL supports it

pawanjay176 · 2024-06-28T10:15:50Z

Strong agree on extending V1. We can implement the V2 method but its unnecessarily complex and gains us nothing imo.

…ectra-engine-api

realbigsean

woop!

beacon_node/beacon_chain/src/electra_readiness.rs

consensus/types/src/chain_spec.rs

realbigsean · 2024-07-01T15:32:22Z

@mergify queue

mergify · 2024-07-01T15:32:39Z

queue

✅ The pull request has been merged automatically

Details

The pull request has been merged automatically at 2a13b4f

eserilev and others added 30 commits April 30, 2024 11:49

Attestation superstruct changes for EIP 7549 (#5644)

3b7132b

* update * experiment * superstruct changes * revert * superstruct changes * fix tests * indexed attestation * indexed attestation superstruct * updated TODOs

Merge remote-tracking branch 'upstream/unstable' into electra_attesta…

3a41e13

…tion_changes

Make EF Tests Fork-Agnostic (#5713)

9b98f4e

Finish EF Test Fork Agnostic (#5714)

7c6526d

Superstruct AggregateAndProof (#5715)

19a9479

* Upgrade `superstruct` to `0.8.0` * superstruct `AggregateAndProof`

Merge remote-tracking branch 'sigp/unstable' into electra_attestation…

9f6de8e

…_changes

cargo fmt

38382a3

Merge pull request #5726 from realbigsean/electra_attestation_changes

2c2e44c

Merge unstable into Electra attestation changes

process withdrawals updates

e2e82ff

cleanup withdrawals processing

e0abede

update process_operations deposit length check

f1f9f92

add apply_deposit changes

3c68841

add execution layer withdrawal request processing

1d5f755

process deposit receipts

32357d8

add consolidation processing

c40bec9

update process operations function

31955c2

exit updates

75ab913

clean up

5728f78

update slash_validator

8517236

EIP7549 get_attestation_indices (#5657)

90179d4

* get attesting indices electra impl * fmt * get tests to pass * fmt * fix some beacon chain tests * fmt * fix slasher test * fmt got me again * fix more tests * fix tests

Some small changes (#5739)

f30246b

Merge branch 'electra_attestation_changes' of https://github.com/sigp…

7c0a8f8

…/lighthouse into block-processing-electra

cargo fmt (#5740)

43c3f63

Merge branch 'electra_attestation_changes' of https://github.com/sigp…

721e73f

…/lighthouse into block-processing-electra

fix attestation verification

7abb762

Add new engine api methods

42a4993

Fix the versioning of v4 requests

ca2a946

Handle new engine api methods in mock EL

1ddd078

Note todo

3ef7c90

realbigsean and others added 10 commits June 21, 2024 10:48

Update slasher/src/database.rs

09141ec

fix imports

8fc5333

Merge pull request #5980 from dapplion/electra-lightclient

5517c78

Add electra lightclient types

Merge pull request #5975 from michaelsproul/electra-slasher-no-migration

cf030d0

Avoid changing slasher schema for Electra

Update beacon_node/beacon_chain/src/attestation_verification.rs

68fd7a7

Update beacon_node/beacon_chain/src/attestation_verification.rs

d137881

Merge branch 'unstable' of https://github.com/sigp/lighthouse into el…

87fde51

…ectra_attestation_changes

Merge branch 'electra_attestation_changes' of https://github.com/real…

a8d84d6

…bigsean/lighthouse into block-processing-electra

Merge branch 'block-processing-electra' of https://github.com/sigp/li…

51a8c80

…ghthouse into electra-epoch-proc

Merge branch 'electra-epoch-proc' of https://github.com/sigp/lighthouse…

4a858b3

… into electra-engine-api

Base automatically changed from block-processing-electra to unstable June 26, 2024 13:29

realbigsean removed the skip-ci Don't run the `test-suite` label Jun 26, 2024

realbigsean changed the base branch from unstable to electra-epoch-proc June 26, 2024 15:12

pawanjay176 added 2 commits June 28, 2024 14:53

The great renaming receipt -> request

806a5eb

Address some more review comments

033457c

Base automatically changed from electra-epoch-proc to unstable June 28, 2024 23:43

Merge branch 'unstable' of https://github.com/sigp/lighthouse into el…

257bcc3

…ectra-engine-api

realbigsean approved these changes Jul 1, 2024

View reviewed changes

beacon_node/beacon_chain/src/electra_readiness.rs Outdated Show resolved Hide resolved

consensus/types/src/chain_spec.rs Outdated Show resolved Hide resolved

realbigsean added 2 commits July 1, 2024 08:21

Update beacon_node/beacon_chain/src/electra_readiness.rs

c9fe10b

Update consensus/types/src/chain_spec.rs

69ac342

mergify bot mentioned this pull request Jul 1, 2024

merge queue: embarking unstable (3f2af5c) and #5743 together #6031

Closed

5 tasks

mergify bot added a commit that referenced this pull request Jul 1, 2024

Merge of #5743

3a08e68

mergify bot merged commit 2a13b4f into unstable Jul 1, 2024

mergify bot deleted the electra-engine-api branch July 1, 2024 16:33

realbigsean restored the electra-engine-api branch July 9, 2024 01:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Electra engine api#5743

Electra engine api#5743
mergify[bot] merged 190 commits intounstablefrom
electra-engine-api

pawanjay176 commented May 8, 2024

Uh oh!

realbigsean commented Jun 26, 2024

Uh oh!

realbigsean commented Jun 26, 2024

Uh oh!

pawanjay176 commented Jun 28, 2024

Uh oh!

realbigsean left a comment

Uh oh!

Uh oh!

Uh oh!

realbigsean commented Jul 1, 2024

Uh oh!

mergify bot commented Jul 1, 2024 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

pawanjay176 commented May 8, 2024

Issue Addressed

Proposed Changes

Additional Info

Uh oh!

realbigsean commented Jun 26, 2024

Uh oh!

realbigsean commented Jun 26, 2024

Uh oh!

pawanjay176 commented Jun 28, 2024

Uh oh!

realbigsean left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

realbigsean commented Jul 1, 2024

Uh oh!

mergify bot commented Jul 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ The pull request has been merged automatically

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

mergify bot commented Jul 1, 2024 •

edited

Loading