Merged
Conversation
* update * experiment * superstruct changes * revert * superstruct changes * fix tests * indexed attestation * indexed attestation superstruct * updated TODOs
* `superstruct` Attester Fork Variants * Push a little further * Deal with Encode / Decode of AttesterSlashing * not so sure about this.. * Stop Encode/Decode Bounds from Propagating Out * Tons of Changes.. * More Conversions to AttestationRef * Add AsReference trait (#15) * Add AsReference trait * Fix some snafus * Got it Compiling! :D * Got Tests Building * Get beacon chain tests compiling --------- Co-authored-by: Michael Sproul <[email protected]>
* Upgrade `superstruct` to `0.8.0` * superstruct `AggregateAndProof`
Merge unstable into Electra attestation changes
* dedup/cleanup and remove unneeded hashset use * remove irrelevant TODOs
* instantiate empty bitlist in unreachable code * clean up error conversion * fork enabled bool cleanup * remove a couple todos * return bools instead of options in `aggregate` and use the result * delete commented out code * use map macros in simple transformations * remove signers_disjoint_from * get ef tests compiling * get ef tests compiling * update intentionally excluded files
dapplion
approved these changes
Jun 21, 2024
Collaborator
dapplion
left a comment
dapplion
left a comment
There was a problem hiding this comment.
All logic is correct with respect to the old spec, good to merge to me if we prefer to update to latest spec latter
consensus/state_processing/src/per_block_processing/process_operations.rs
Outdated
Show resolved
Hide resolved
| continue; | ||
| } | ||
|
|
||
| let pending_balance_to_withdraw = state.get_pending_balance_to_withdraw(index)?; |
Collaborator
There was a problem hiding this comment.
get_pending_balance_to_withdraw iterates over the full list of withdrawals making it a O(n^2) operation technically. We process only a few withdrawal requests per block, but we should watch to ensure we don't need a cache.
Member
Author
There was a problem hiding this comment.
maybe we should add per-operations metrics in a separate pr?
Add electra lightclient types
Avoid changing slasher schema for Electra
Member
Author
|
@mergify queue |
✅ The pull request has been merged automaticallyDetailsThe pull request has been merged automatically at 858b01f |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
#5605
Tasks