One less listen address race#5718
Merged
mergify[bot] merged 1 commit intosigp:unstablefrom May 6, 2024
Merged
Conversation
michaelsproul
added
test improvement
michaelsproul
added
ready-for-merge
Member
Author
|
@Mergifyio queue |
✅ The pull request has been merged automaticallyDetailsThe pull request has been merged automatically at fe20ef9 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Fix some port reuse failures in the
watchtests, e.g. https://github.com/sigp/lighthouse/actions/runs/8962018242/job/24610283078Proposed Changes
Listen on port 0 for the
watchHTTP server.Additional Info
We can't fully solve the port reuse races in the
watchtests because it's hard to read the listen address from an external process (postgres) listening on port 0. Still, this PR should improve things a little.