Skip to content

Improve logging and metrics for block publication#5699

Merged
mergify[bot] merged 3 commits intosigp:unstablefrom
michaelsproul:publish_block_ms
May 3, 2024
Merged

Improve logging and metrics for block publication#5699
mergify[bot] merged 3 commits intosigp:unstablefrom
michaelsproul:publish_block_ms

Conversation

@michaelsproul
Copy link
Member

@michaelsproul michaelsproul commented May 3, 2024

Proposed Changes

  • Print the block publish delay in milliseconds, which makes it easier to parse and process. This is a change that some relays have previously asked for.
  • Add a new metric tracking block gossip time in the HTTP API, which matches the publish_delay_ms log.
  • Fix Clippy for Rust 1.78 just released

@michaelsproul michaelsproul added the ready-for-review The code is ready for review label May 3, 2024
@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. v5.2.0 Q2 2024 and removed ready-for-review The code is ready for review labels May 3, 2024
@michaelsproul michaelsproul mentioned this pull request May 3, 2024
Merged
@michaelsproul
Copy link
Member Author

michaelsproul commented May 3, 2024

@Mergifyio queue

@mergify
Copy link

mergify bot commented May 3, 2024 •
edited
Loading

queue

🛑 The pull request has been removed from the queue default

Details

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

michaelsproul added a commit that referenced this pull request May 3, 2024
@michaelsproul
Improve logging and metrics for block publication (#5699)
6ee65ee 
Squashed commit of the following:

commit 0e3b0a1
Author: Michael Sproul <[email protected]>
Date:   Fri May 3 10:35:42 2024 +1000

    Add better buckets

commit 2f09bea
Author: Michael Sproul <[email protected]>
Date:   Fri May 3 10:25:47 2024 +1000

    Improve logging and metrics for block publication
@michaelsproul michaelsproul mentioned this pull request May 3, 2024
Merged
@michaelsproul
Copy link
Member Author

michaelsproul commented May 3, 2024

@Mergifyio requeue

@mergify
Copy link

mergify bot commented May 3, 2024

requeue

✅ This pull request will be re-embarked automatically

Details

The followup queue command will be automatically executed to re-embark the pull request

@mergify
Copy link

mergify bot commented May 3, 2024 •
edited
Loading

queue

🛑 The pull request has been removed from the queue default

Details

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@michaelsproul
Copy link
Member Author

michaelsproul commented May 3, 2024

@Mergifyio requeue

@mergify
Copy link

mergify bot commented May 3, 2024

requeue

✅ This pull request will be re-embarked automatically

Details

The followup queue command will be automatically executed to re-embark the pull request

@mergify
Copy link

mergify bot commented May 3, 2024 •
edited
Loading

queue

🛑 The pull request has been removed from the queue default

Details

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@jimmygchen
Copy link
Member

jimmygchen commented May 3, 2024

@mergify requeue

@mergify
Copy link

mergify bot commented May 3, 2024

requeue

✅ This pull request will be re-embarked automatically

Details

The followup queue command will be automatically executed to re-embark the pull request

@mergify
Copy link

mergify bot commented May 3, 2024 •
edited
Loading

queue

🛑 The pull request has been removed from the queue default

Details

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

mergify bot added a commit that referenced this pull request May 3, 2024
@mergify
Merge of #5699
cdb7033
@mergify mergify bot mentioned this pull request May 3, 2024
Closed
6 tasks
@jimmygchen
Copy link
Member

jimmygchen commented May 3, 2024

@mergify requeue

@mergify
Copy link

mergify bot commented May 3, 2024

requeue

✅ This pull request will be re-embarked automatically

Details

The followup queue command will be automatically executed to re-embark the pull request

@mergify
Copy link

mergify bot commented May 3, 2024 •
edited
Loading

queue

🛑 The pull request has been removed from the queue default

Details

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@jimmygchen
Copy link
Member

jimmygchen commented May 3, 2024

@mergify requeue

@mergify
Copy link

mergify bot commented May 3, 2024

requeue

✅ This pull request will be re-embarked automatically

Details

The followup queue command will be automatically executed to re-embark the pull request

@mergify
Copy link

mergify bot commented May 3, 2024 •
edited
Loading

queue

🛑 The pull request has been removed from the queue default

Details

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@jimmygchen
Copy link
Member

jimmygchen commented May 3, 2024

@mergify requeue

@mergify
Copy link

mergify bot commented May 3, 2024

requeue

❌ This pull request head commit has not been previously disembarked from queue.

@jimmygchen
Copy link
Member

jimmygchen commented May 3, 2024

@mergify queue

@mergify
Copy link

mergify bot commented May 3, 2024 •
edited
Loading

queue

🛑 The pull request has been removed from the queue default

Details

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@jimmygchen
Copy link
Member

jimmygchen commented May 3, 2024

@mergify requeue

@mergify
Copy link

mergify bot commented May 3, 2024

requeue

✅ This pull request will be re-embarked automatically

Details

The followup queue command will be automatically executed to re-embark the pull request

@mergify
Copy link

mergify bot commented May 3, 2024 •
edited
Loading

queue

🛑 The pull request has been removed from the queue default

Details

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@jimmygchen
Copy link
Member

jimmygchen commented May 3, 2024

@Mergifyio unqueue

@mergify
Copy link

mergify bot commented May 3, 2024

unqueue

☑️ The pull request is not queued

@jimmygchen
Copy link
Member

jimmygchen commented May 3, 2024

@mergify requeue

@mergify
Copy link

mergify bot commented May 3, 2024

requeue

✅ This pull request will be re-embarked automatically

Details

The followup queue command will be automatically executed to re-embark the pull request

@mergify
Copy link

mergify bot commented May 3, 2024 •
edited
Loading

queue

🛑 The pull request has been removed from the queue default

Details

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@jimmygchen
Copy link
Member

jimmygchen commented May 3, 2024

@mergify queue

@mergify
Copy link

mergify bot commented May 3, 2024 •
edited
Loading

queue

✅ The pull request has been merged automatically

Details

The pull request has been merged automatically at d3d429f

@mergify mergify bot merged commit d3d429f into sigp:unstable May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pawanjay176 pawanjay176 pawanjay176 approved these changes

Assignees

No one assigned

Labels

ready-for-merge This PR is ready to merge. v5.2.0 Q2 2024

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@michaelsproul @jimmygchen @pawanjay176