Make modified helpers in electra fork aware#5698
Merged
mergify[bot] merged 3 commits intosigp:unstablefrom May 3, 2024
Merged
Conversation
pawanjay176
added
ready-for-review
michaelsproul
added a commit
that referenced
this pull request
May 3, 2024
Squashed commit of the following: commit 64440c4 Author: Pawan Dhananjay <[email protected]> Date: Thu May 2 17:42:15 2024 -0700 Make more functions fork aware commit 40397fb Author: Pawan Dhananjay <[email protected]> Date: Thu May 2 17:14:41 2024 -0700 Make modified helpers in electra fork aware
Merged
jimmygchen
added
the
consensus
jimmygchen
approved these changes
May 3, 2024
Member
jimmygchen
left a comment
jimmygchen
left a comment
There was a problem hiding this comment.
LGTM. Confirmed that existing pre-electra logic unchanged.
michaelsproul
approved these changes
May 3, 2024
jimmygchen
added
ready-for-merge
Member
|
@mergify queue |
✅ The pull request has been merged automaticallyDetailsThe pull request has been merged automatically at 1af3f0f |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
N/A
Proposed Changes
In #5653 , we modified a bunch of functions for electra without making them fork aware.
This PR aims to make the functions that the spec marks as "Modified in electra" fork aware.
Additional info
I intend to create pre and post electra versions for existing functions that are modified in the electra spec even if the logic doesn't change to make sure we don't shoot ourself in the foot in cases like these in the future.