Skip to content

Conversation

@jimmygchen
Copy link
Member

@jimmygchen jimmygchen commented Nov 17, 2023

Issue Addressed

Fix new warnings from new Rust beta compiler (rustc 1.75.0-beta.1).

Also:

  • Add clippy::enum_variant_names to allowed list. We prefer Error::BeaconStateError over Error::BeaconState.
  • Ignore some unused_imports in watch::database as they seem to be false positives. We could probably change the way we do imports within watch as it isn't used elsewhere, but it won't allow us to arrange it the way it currently is, i.e. re-exporting database related functions via the watch::database module.

Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jimmygchen jimmygchen added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Nov 17, 2023
@jimmygchen jimmygchen merged commit 6b63d18 into sigp:unstable Nov 17, 2023
@jimmygchen jimmygchen deleted the fix-beta-compiler-warns branch November 17, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code-quality ready-for-merge This PR is ready to merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants