[Merged by Bors] - Remove hidden re-exports to appease Rust 1.73#4495
Closed
jmcph4 wants to merge 2 commits intosigp:unstablefrom
jmcph4:4494-rust-1-73-break
Closed
[Merged by Bors] - Remove hidden re-exports to appease Rust 1.73#4495jmcph4 wants to merge 2 commits intosigp:unstablefrom jmcph4:4494-rust-1-73-break
jmcph4 wants to merge 2 commits intosigp:unstablefrom
jmcph4:4494-rust-1-73-break
Conversation
jmcph4
changed the title
jmcph4
added
low-hanging-fruit
michaelsproul
approved these changes
Jul 12, 2023
Member
michaelsproul
left a comment
michaelsproul
left a comment
There was a problem hiding this comment.
Looks great, thanks for handling that!
michaelsproul
added
ready-for-merge
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jul 12, 2023
## Issue Addressed #4494 ## Proposed Changes - Remove explicit re-exports of various types to appease the new compiler lint ## Additional Info It seems `warn(hidden_glob_reexports)` is the main culprit.
|
This PR was included in a batch that timed out, it will be automatically retried |
bors bot
pushed a commit
that referenced
this pull request
Jul 12, 2023
## Issue Addressed #4494 ## Proposed Changes - Remove explicit re-exports of various types to appease the new compiler lint ## Additional Info It seems `warn(hidden_glob_reexports)` is the main culprit.
|
Pull request successfully merged into unstable. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page.
|
bors
bot
changed the title
Woodpile37
pushed a commit
to Woodpile37/lighthouse
that referenced
this pull request
Jan 6, 2024
- Remove explicit re-exports of various types to appease the new compiler lint It seems `warn(hidden_glob_reexports)` is the main culprit.
Woodpile37
pushed a commit
to Woodpile37/lighthouse
that referenced
this pull request
Jan 6, 2024
- Remove explicit re-exports of various types to appease the new compiler lint It seems `warn(hidden_glob_reexports)` is the main culprit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
#4494
Proposed Changes
Additional Info
It seems
warn(hidden_glob_reexports)is the main culprit.