Skip to content

[Merged by Bors] - Remove instances of required arguments with default values#4489

Closed
jmcph4 wants to merge 2 commits intosigp:unstablefrom
jmcph4:4488-remove-required-args-with-defaults
Closed

[Merged by Bors] - Remove instances of required arguments with default values#4489
jmcph4 wants to merge 2 commits intosigp:unstablefrom
jmcph4:4488-remove-required-args-with-defaults

Conversation

@jmcph4
Copy link
Contributor

@jmcph4 jmcph4 commented Jul 11, 2023

Issue Addressed

#4488

Proposed Changes

  • Remove all instances of the required modifier where we have a default value specified for a subcommand

Additional Info

N/A

@jmcph4 jmcph4 self-assigned this Jul 11, 2023
@jmcph4 jmcph4 requested review from jimmygchen and paulhauner July 11, 2023 03:58
@jmcph4 jmcph4 added ready-for-review The code is ready for review v4.4.1 ETA August 2023 labels Jul 11, 2023
paulhauner
paulhauner approved these changes Jul 11, 2023
View reviewed changes
Copy link
Member

@paulhauner paulhauner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@paulhauner paulhauner added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Jul 11, 2023
jimmygchen
jimmygchen reviewed Jul 11, 2023
View reviewed changes
jimmygchen
jimmygchen approved these changes Jul 11, 2023
View reviewed changes
Copy link
Member

@jimmygchen jimmygchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@jmcph4
Copy link
Contributor Author

jmcph4 commented Jul 11, 2023

bors r+

@bors
Copy link

bors bot commented Jul 11, 2023

🔒 Permission denied

Existing reviewers: click here to make jmcph4 a reviewer

@jmcph4
Copy link
Contributor Author

jmcph4 commented Jul 11, 2023

lock Permission denied

Existing reviewers: click here to make jmcph4 a reviewer

That confirms it 😄

@michaelsproul
Copy link
Member

michaelsproul commented Jul 11, 2023

bors r+

bors bot pushed a commit that referenced this pull request Jul 11, 2023
@jmcph4
Remove instances of required arguments with default values (#4489)
a0bf52b 
## Issue Addressed

#4488 

## Proposed Changes

 - Remove all instances of the `required` modifier where we have a default value specified for a subcommand

## Additional Info

N/A
@bors
Copy link

bors bot commented Jul 12, 2023

Timed out.

@michaelsproul
Copy link
Member

michaelsproul commented Jul 12, 2023

bors r+

bors bot pushed a commit that referenced this pull request Jul 12, 2023
@jmcph4
Remove instances of required arguments with default values (#4489)
90b923f 
## Issue Addressed

#4488 

## Proposed Changes

 - Remove all instances of the `required` modifier where we have a default value specified for a subcommand

## Additional Info

N/A
@bors
Copy link

bors bot commented Jul 12, 2023

This PR was included in a batch that timed out, it will be automatically retried

bors bot pushed a commit that referenced this pull request Jul 12, 2023
@jmcph4
Remove instances of required arguments with default values (#4489)
b26ce13 
## Issue Addressed

#4488 

## Proposed Changes

 - Remove all instances of the `required` modifier where we have a default value specified for a subcommand

## Additional Info

N/A
@bors
Copy link

bors bot commented Jul 12, 2023

Build failed (retrying...):

@michaelsproul
Copy link
Member

michaelsproul commented Jul 12, 2023

bors r+

@bors
Copy link

bors bot commented Jul 12, 2023

Already running a review

bors bot pushed a commit that referenced this pull request Jul 12, 2023
@jmcph4
Remove instances of required arguments with default values (#4489)
f42baf6 
## Issue Addressed

#4488 

## Proposed Changes

 - Remove all instances of the `required` modifier where we have a default value specified for a subcommand

## Additional Info

N/A
@bors
Copy link

bors bot commented Jul 12, 2023

This PR was included in a batch that timed out, it will be automatically retried

bors bot pushed a commit that referenced this pull request Jul 12, 2023
@jmcph4
Remove instances of required arguments with default values (#4489)
628bbdd 
## Issue Addressed

#4488 

## Proposed Changes

 - Remove all instances of the `required` modifier where we have a default value specified for a subcommand

## Additional Info

N/A
@bors
Copy link

bors bot commented Jul 12, 2023

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Jul 13, 2023
@jmcph4
Remove instances of required arguments with default values (#4489)
eaeadf5 
## Issue Addressed

#4488 

## Proposed Changes

 - Remove all instances of the `required` modifier where we have a default value specified for a subcommand

## Additional Info

N/A
@michaelsproul
Copy link
Member

michaelsproul commented Jul 13, 2023

bors r-

@bors
Copy link

bors bot commented Jul 13, 2023

Canceled.

@michaelsproul
Copy link
Member

michaelsproul commented Jul 13, 2023

bors r+

bors bot pushed a commit that referenced this pull request Jul 13, 2023
@jmcph4
Remove instances of required arguments with default values (#4489)
f42f5c0 
## Issue Addressed

#4488 

## Proposed Changes

 - Remove all instances of the `required` modifier where we have a default value specified for a subcommand

## Additional Info

N/A
@bors
Copy link

bors bot commented Jul 13, 2023

Build failed (retrying...):

@michaelsproul
Copy link
Member

michaelsproul commented Jul 13, 2023

re-batching because of the simulator failure

bors r-

@bors
Copy link

bors bot commented Jul 13, 2023

Canceled.

@michaelsproul
Copy link
Member

michaelsproul commented Jul 13, 2023

bors r+

bors bot pushed a commit that referenced this pull request Jul 13, 2023
@jmcph4
Remove instances of required arguments with default values (#4489)
ed981e4 
## Issue Addressed

#4488 

## Proposed Changes

 - Remove all instances of the `required` modifier where we have a default value specified for a subcommand

## Additional Info

N/A
@bors
Copy link

bors bot commented Jul 13, 2023

This PR was included in a batch that timed out, it will be automatically retried

bors bot pushed a commit that referenced this pull request Jul 13, 2023
@jmcph4
Remove instances of required arguments with default values (#4489)
b2893b3 
## Issue Addressed

#4488 

## Proposed Changes

 - Remove all instances of the `required` modifier where we have a default value specified for a subcommand

## Additional Info

N/A
@bors
Copy link

bors bot commented Jul 13, 2023

Build failed (retrying...):

@michaelsproul
Copy link
Member

michaelsproul commented Jul 13, 2023

bors r-
bors +

@bors
Copy link

bors bot commented Jul 13, 2023

Did you mean "r+"?

@michaelsproul
Copy link
Member

michaelsproul commented Jul 13, 2023

bors r+

@michaelsproul
Copy link
Member

michaelsproul commented Jul 13, 2023

bors r-
bors r+

@bors
Copy link

bors bot commented Jul 13, 2023

Canceled.

bors bot pushed a commit that referenced this pull request Jul 13, 2023
@jmcph4
Remove instances of required arguments with default values (#4489)
f02a438 
## Issue Addressed

#4488 

## Proposed Changes

 - Remove all instances of the `required` modifier where we have a default value specified for a subcommand

## Additional Info

N/A
@bors
Copy link

bors bot commented Jul 14, 2023

This PR was included in a batch that timed out, it will be automatically retried

bors bot pushed a commit that referenced this pull request Jul 14, 2023
@jmcph4
Remove instances of required arguments with default values (#4489)
c9e67ff 
## Issue Addressed

#4488 

## Proposed Changes

 - Remove all instances of the `required` modifier where we have a default value specified for a subcommand

## Additional Info

N/A
@michaelsproul
Copy link
Member

michaelsproul commented Jul 14, 2023

bors r-

@bors
Copy link

bors bot commented Jul 14, 2023

Canceled.

@michaelsproul
Copy link
Member

michaelsproul commented Jul 17, 2023

bors r+

bors bot pushed a commit that referenced this pull request Jul 17, 2023
@jmcph4
Remove instances of required arguments with default values (#4489)
1a5de8b 
## Issue Addressed

#4488 

## Proposed Changes

 - Remove all instances of the `required` modifier where we have a default value specified for a subcommand

## Additional Info

N/A
@bors
Copy link

bors bot commented Jul 17, 2023

Pull request successfully merged into unstable.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title Remove instances of required arguments with default values [Merged by Bors] - Remove instances of required arguments with default values Jul 17, 2023
@bors bors bot closed this Jul 17, 2023
Woodpile37 pushed a commit to Woodpile37/lighthouse that referenced this pull request Jan 6, 2024
@jmcph4 @Woodpile37
Remove instances of required arguments with default values (sigp#4489)
0b013ea 
## Issue Addressed

sigp#4488 

## Proposed Changes

 - Remove all instances of the `required` modifier where we have a default value specified for a subcommand

## Additional Info

N/A
Woodpile37 pushed a commit to Woodpile37/lighthouse that referenced this pull request Jan 6, 2024
@jmcph4 @Woodpile37
Remove instances of required arguments with default values (sigp#4489)
98d7760 
## Issue Addressed

sigp#4488 

## Proposed Changes

 - Remove all instances of the `required` modifier where we have a default value specified for a subcommand

## Additional Info

N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jimmygchen jimmygchen jimmygchen approved these changes

@paulhauner paulhauner paulhauner approved these changes

Assignees

@jmcph4 jmcph4

Labels

ready-for-merge This PR is ready to merge. v4.4.1 ETA August 2023

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jmcph4 @michaelsproul @jimmygchen @paulhauner