[Merged by Bors] - Correct checks for backfill completeness#4465
Closed
jmcph4 wants to merge 5 commits intosigp:unstablefrom
jmcph4:4331-backfill-stuck
Closed
[Merged by Bors] - Correct checks for backfill completeness#4465jmcph4 wants to merge 5 commits intosigp:unstablefrom jmcph4:4331-backfill-stuck
jmcph4 wants to merge 5 commits intosigp:unstablefrom
jmcph4:4331-backfill-stuck
Conversation
divagant-martian
approved these changes
Jul 5, 2023
Co-authored-by: Divma <[email protected]>
AgeManning
added
ready-for-merge
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jul 6, 2023
## Issue Addressed #4331 ## Proposed Changes - Use comparison rather than strict equality between the earliest epoch we know about and the backfill target (which will be the most recent WSP by default or genesis) - Add helper function `BackFillSync<T>::would_complete` to achieve this in one location ## Additional Info - There's an ad hoc test for this in #4461 Co-authored-by: Age Manning <[email protected]>
|
Pull request successfully merged into unstable. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page.
|
bors
bot
changed the title
This was referenced Jul 7, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
#4331
Proposed Changes
BackFillSync<T>::would_completeto achieve this in one locationAdditional Info