[Merged by Bors] - Do not attempt to resubscribe to core topics#4271
Closed
jmcph4 wants to merge 2 commits intosigp:unstablefrom
jmcph4:4258-resubscribe-core-topics
Closed
[Merged by Bors] - Do not attempt to resubscribe to core topics#4271jmcph4 wants to merge 2 commits intosigp:unstablefrom jmcph4:4258-resubscribe-core-topics
jmcph4 wants to merge 2 commits intosigp:unstablefrom
jmcph4:4258-resubscribe-core-topics
Conversation
This commit adds a check to the networking service when handling core gossipsub topic subscription requests. If the BN is already subscribed to the core topics, this call becomes a no-op.
divagant-martian
changed the title
AgeManning
approved these changes
May 8, 2023
Member
AgeManning
left a comment
AgeManning
left a comment
There was a problem hiding this comment.
This looks good to me. Nice work
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
May 8, 2023
This commit adds a check to the networking service when handling core gossipsub topic subscription requests. If the BN is already subscribed to the core topics, we won't attempt to resubscribe. ## Issue Addressed #4258 ## Proposed Changes - In the networking service, check if we're already subscribed to all of the core gossipsub topics and, if so, do nothing ## Additional Info N/A
|
Pull request successfully merged into unstable. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page.
|
bors
bot
changed the title
ghost
pushed a commit
to oone-world/lighthouse
that referenced
this pull request
Jul 13, 2023
This commit adds a check to the networking service when handling core gossipsub topic subscription requests. If the BN is already subscribed to the core topics, we won't attempt to resubscribe. ## Issue Addressed sigp#4258 ## Proposed Changes - In the networking service, check if we're already subscribed to all of the core gossipsub topics and, if so, do nothing ## Additional Info N/A
Woodpile37
pushed a commit
to Woodpile37/lighthouse
that referenced
this pull request
Jan 6, 2024
This commit adds a check to the networking service when handling core gossipsub topic subscription requests. If the BN is already subscribed to the core topics, we won't attempt to resubscribe. ## Issue Addressed sigp#4258 ## Proposed Changes - In the networking service, check if we're already subscribed to all of the core gossipsub topics and, if so, do nothing ## Additional Info N/A
Woodpile37
pushed a commit
to Woodpile37/lighthouse
that referenced
this pull request
Jan 6, 2024
This commit adds a check to the networking service when handling core gossipsub topic subscription requests. If the BN is already subscribed to the core topics, we won't attempt to resubscribe. ## Issue Addressed sigp#4258 ## Proposed Changes - In the networking service, check if we're already subscribed to all of the core gossipsub topics and, if so, do nothing ## Additional Info N/A
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds a check to the networking service when handling core gossipsub topic subscription requests. If the BN is already subscribed to the core topics, we won't attempt to resubscribe.
Issue Addressed
#4258
Proposed Changes
Additional Info
N/A