Skip to content

[Merged by Bors] - Set user agent on requests to builder#4199

Closed
michaelsproul wants to merge 2 commits intosigp:unstablefrom
michaelsproul:builder-agent
Closed

[Merged by Bors] - Set user agent on requests to builder#4199
michaelsproul wants to merge 2 commits intosigp:unstablefrom
michaelsproul:builder-agent

Conversation

@michaelsproul
Copy link
Member

Issue Addressed

Closes #4185

Proposed Changes

  • Set user agent to Lighthouse/vX.Y.Z-<commit hash> by default
  • Allow tweaking user agent via --builder-user-agent "agent"

@michaelsproul michaelsproul added enhancement New feature or request ready-for-review The code is ready for review low-hanging-fruit Easy to resolve, get it before someone else does! builder API labels Apr 17, 2023
@michaelsproul michaelsproul added the v4.1.0 Post-Capella minor release label Apr 18, 2023
Copy link
Member

@paulhauner paulhauner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I made a suggestion, it's not important though. Happy to merge as-is.

@michaelsproul
Copy link
Member Author

bors r+

bors bot pushed a commit that referenced this pull request Apr 18, 2023
## Issue Addressed

Closes #4185

## Proposed Changes

- Set user agent to `Lighthouse/vX.Y.Z-<commit hash>` by default
- Allow tweaking user agent via `--builder-user-agent "agent"`
@bors bors bot changed the title Set user agent on requests to builder [Merged by Bors] - Set user agent on requests to builder Apr 18, 2023
@bors bors bot closed this Apr 18, 2023
@michaelsproul michaelsproul deleted the builder-agent branch April 18, 2023 05:25
xenowits pushed a commit to xenowits/lighthouse that referenced this pull request May 16, 2023
## Issue Addressed

Closes sigp#4185

## Proposed Changes

- Set user agent to `Lighthouse/vX.Y.Z-<commit hash>` by default
- Allow tweaking user agent via `--builder-user-agent "agent"`
ghost pushed a commit to oone-world/lighthouse that referenced this pull request Jul 13, 2023
## Issue Addressed

Closes sigp#4185

## Proposed Changes

- Set user agent to `Lighthouse/vX.Y.Z-<commit hash>` by default
- Allow tweaking user agent via `--builder-user-agent "agent"`
Woodpile37 pushed a commit to Woodpile37/lighthouse that referenced this pull request Jan 6, 2024
## Issue Addressed

Closes sigp#4185

## Proposed Changes

- Set user agent to `Lighthouse/vX.Y.Z-<commit hash>` by default
- Allow tweaking user agent via `--builder-user-agent "agent"`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

builder API enhancement New feature or request low-hanging-fruit Easy to resolve, get it before someone else does! ready-for-review The code is ready for review v4.1.0 Post-Capella minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants