Closed
Conversation
|
with maxperf this reduces spikes from all cores ~70%+ to ~20%+ on a ryzen 9 5950x so might still be hitting hard for pi 4's |
paulhauner
added
do-not-merge
and removed
ready-for-review
Member
Author
|
I don't think we should merge this branch into Rather, I think we should keep this branch around (i.e., not deleted) so it can be pulled by users and we should make another PR to merge into |
bors bot
pushed a commit
that referenced
this pull request
Apr 14, 2023
## Issue Addressed NA ## Proposed Changes Similar to #4181 but without the version bump and a more nuanced fix. Patches the high CPU usage seen after the Capella fork which was caused by processing exits when there are skip slots. ## Additional Info ~~This is an imperfect solution that will cause us to drop some exits at the fork boundary. This is tracked at #4184.~~
|
@paulhauner @michaelsproul Will there be a release without the -rc suffix? |
Member
Member
Author
|
Please expect this branch to be deleted in the near future. All users should prefer the latest release (v4.1.0 at the time of writing). |
Member
Author
|
I'm closing this PR but leaving the branch around for the time being. All users should prefer the latest release (v4.1.0 at the time of writing). |
ghost
pushed a commit
to oone-world/lighthouse
that referenced
this pull request
Jul 13, 2023
## Issue Addressed NA ## Proposed Changes Similar to sigp#4181 but without the version bump and a more nuanced fix. Patches the high CPU usage seen after the Capella fork which was caused by processing exits when there are skip slots. ## Additional Info ~~This is an imperfect solution that will cause us to drop some exits at the fork boundary. This is tracked at sigp#4184.~~
Woodpile37
pushed a commit
to Woodpile37/lighthouse
that referenced
this pull request
Jan 6, 2024
## Issue Addressed NA ## Proposed Changes Similar to sigp#4181 but without the version bump and a more nuanced fix. Patches the high CPU usage seen after the Capella fork which was caused by processing exits when there are skip slots. ## Additional Info ~~This is an imperfect solution that will cause us to drop some exits at the fork boundary. This is tracked at sigp#4184.~~
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
NA
Proposed Changes
Avoids clones and state-skips of the head state when an exit is verified across a skip slot.
Additional Info
NA