[Merged by Bors] - CI fix: move download web3signer binary out of build script#4163
Closed
jimmygchen wants to merge 4 commits intosigp:unstablefrom
Closed
[Merged by Bors] - CI fix: move download web3signer binary out of build script#4163jimmygchen wants to merge 4 commits intosigp:unstablefrom
jimmygchen wants to merge 4 commits intosigp:unstablefrom
Conversation
Member
Author
|
@michaelsproul I've moved the download out of the build script to the tests, and it seems to be working! There's one job failure due to port conflicts in the eth1 simulator tests, but I don't think it's related to the change. |
jimmygchen
added
ready-for-review
michaelsproul
approved these changes
Apr 6, 2023
Member
michaelsproul
left a comment
michaelsproul
left a comment
There was a problem hiding this comment.
Looks great! Thanks for taking the initiative on this!
michaelsproul
added
waiting-on-author
jimmygchen
added
ready-for-review
michaelsproul
added
ready-for-merge
Member
|
Nice! Let's go! bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Apr 6, 2023
## Issue Addressed Attempt to fix #3812 ## Proposed Changes Move web3signer binary download script out of build script to avoid downloading unless necessary. If this works, it should also reduce the build time for all jobs that runs compilation.
bors
bot
changed the title
ghost
pushed a commit
to oone-world/lighthouse
that referenced
this pull request
Jul 13, 2023
## Issue Addressed Attempt to fix sigp#3812 ## Proposed Changes Move web3signer binary download script out of build script to avoid downloading unless necessary. If this works, it should also reduce the build time for all jobs that runs compilation.
Woodpile37
pushed a commit
to Woodpile37/lighthouse
that referenced
this pull request
Jan 6, 2024
## Issue Addressed Attempt to fix sigp#3812 ## Proposed Changes Move web3signer binary download script out of build script to avoid downloading unless necessary. If this works, it should also reduce the build time for all jobs that runs compilation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Attempt to fix #3812
Proposed Changes
Move web3signer binary download script out of build script to avoid downloading unless necessary. If this works, it should also reduce the build time for all jobs that runs compilation.