[Merged by Bors] - Post merge local testnets#3807
Closed
pawanjay176 wants to merge 34 commits intosigp:unstablefrom
Closed
[Merged by Bors] - Post merge local testnets#3807pawanjay176 wants to merge 34 commits intosigp:unstablefrom
pawanjay176 wants to merge 34 commits intosigp:unstablefrom
Conversation
Closed
3 tasks
pawanjay176
force-pushed
the
merge-local-testnet
branch
from
30e5424 to
d4c39b6
Compare
jimmygchen
reviewed
Apr 14, 2023
jimmygchen
reviewed
Apr 14, 2023
jimmygchen
reviewed
Apr 14, 2023
jimmygchen
reviewed
Apr 14, 2023
jimmygchen
reviewed
Apr 14, 2023
jimmygchen
reviewed
Apr 14, 2023
jimmygchen
reviewed
Apr 14, 2023
jimmygchen
reviewed
Apr 14, 2023
paulhauner
reviewed
May 16, 2023
Member
paulhauner
left a comment
paulhauner
left a comment
There was a problem hiding this comment.
The mnemonic-validators stuff looks good to me! I just have a minor suggestion about CLI help text.
paulhauner
approved these changes
May 16, 2023
Member
paulhauner
left a comment
paulhauner
left a comment
There was a problem hiding this comment.
Looks good, just a couple of super minor suggestions.
paulhauner
added
waiting-on-author
Co-authored-by: Paul Hauner <[email protected]>
pawanjay176
added
ready-for-review
paulhauner
requested changes
May 17, 2023
Member
paulhauner
left a comment
paulhauner
left a comment
There was a problem hiding this comment.
It looks like the local-testnet action is failing: https://github.com/sigp/lighthouse/actions/runs/4988153508
I've made some suggestions that might fix it?
paulhauner
added
waiting-on-author
Co-authored-by: Paul Hauner <[email protected]>
Member
Author
|
@paulhauner Fixed the local testnet CI |
paulhauner
added
ready-for-merge
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
May 17, 2023
## Issue Addressed N/A ## Proposed Changes Modifies the local testnet scripts to start a network with genesis validators embedded into the genesis state. This allows us to start a local testnet without the need for deploying a deposit contract or depositing validators pre-genesis. This also enables us to start a local test network at any fork we want without going through fork transitions. Also adds scripts to start multiple geth clients and peer them with each other and peer the geth clients with beacon nodes to start a post merge local testnet. ## Additional info Adds a new lcli command `mnemonics-validators` that generates validator directories derived from a given mnemonic. Adds a new `derived-genesis-state` option to the `lcli new-testnet` command to generate a genesis state populated with validators derived from a mnemonic.
|
Pull request successfully merged into unstable. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page.
|
bors
bot
changed the title
ghost
pushed a commit
to oone-world/lighthouse
that referenced
this pull request
Jul 13, 2023
## Issue Addressed N/A ## Proposed Changes Modifies the local testnet scripts to start a network with genesis validators embedded into the genesis state. This allows us to start a local testnet without the need for deploying a deposit contract or depositing validators pre-genesis. This also enables us to start a local test network at any fork we want without going through fork transitions. Also adds scripts to start multiple geth clients and peer them with each other and peer the geth clients with beacon nodes to start a post merge local testnet. ## Additional info Adds a new lcli command `mnemonics-validators` that generates validator directories derived from a given mnemonic. Adds a new `derived-genesis-state` option to the `lcli new-testnet` command to generate a genesis state populated with validators derived from a mnemonic.
Woodpile37
pushed a commit
to Woodpile37/lighthouse
that referenced
this pull request
Jan 6, 2024
N/A Modifies the local testnet scripts to start a network with genesis validators embedded into the genesis state. This allows us to start a local testnet without the need for deploying a deposit contract or depositing validators pre-genesis. This also enables us to start a local test network at any fork we want without going through fork transitions. Also adds scripts to start multiple geth clients and peer them with each other and peer the geth clients with beacon nodes to start a post merge local testnet. Adds a new lcli command `mnemonics-validators` that generates validator directories derived from a given mnemonic. Adds a new `derived-genesis-state` option to the `lcli new-testnet` command to generate a genesis state populated with validators derived from a mnemonic.
Woodpile37
pushed a commit
to Woodpile37/lighthouse
that referenced
this pull request
Jan 6, 2024
N/A Modifies the local testnet scripts to start a network with genesis validators embedded into the genesis state. This allows us to start a local testnet without the need for deploying a deposit contract or depositing validators pre-genesis. This also enables us to start a local test network at any fork we want without going through fork transitions. Also adds scripts to start multiple geth clients and peer them with each other and peer the geth clients with beacon nodes to start a post merge local testnet. Adds a new lcli command `mnemonics-validators` that generates validator directories derived from a given mnemonic. Adds a new `derived-genesis-state` option to the `lcli new-testnet` command to generate a genesis state populated with validators derived from a mnemonic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
N/A
Proposed Changes
Modifies the local testnet scripts to start a network with genesis validators embedded into the genesis state. This allows us to start a local testnet without the need for deploying a deposit contract or depositing validators pre-genesis.
This also enables us to start a local test network at any fork we want without going through fork transitions. Also adds scripts to start multiple geth clients and peer them with each other and peer the geth clients with beacon nodes to start a post merge local testnet.
Additional info
Adds a new lcli command
mnemonics-validatorsthat generates validator directories derived from a given mnemonic.Adds a new
derived-genesis-stateoption to thelcli new-testnetcommand to generate a genesis state populated with validators derived from a mnemonic.