[Merged by Bors] - Add beacon.watch#3362
Closed
macladson wants to merge 23 commits intosigp:unstablefrom
Closed
Conversation
macladson
force-pushed
the
beacon-watch
branch
from
d2be6c0 to
08f4f0f
Compare
macladson
force-pushed
the
beacon-watch
branch
from
08f4f0f to
ac74de5
Compare
macladson
force-pushed
the
beacon-watch
branch
4 times, most recently
from
7ec5a3a to
2683e39
Compare
macladson
force-pushed
the
beacon-watch
branch
from
db1e2e7 to
91bf529
Compare
paulhauner
approved these changes
Jan 20, 2023
Member
paulhauner
left a comment
paulhauner
left a comment
There was a problem hiding this comment.
This looks great! I'm impressed at how clean and neatly structured it is! I really enjoyed playing around with the API too, I think it'll be great to see this with a GUI.
As discussed, I don't think this calls for a "check every piece of logic review", however I have read through it all. Once again, I was impressed at how neat and we'll commented it is.
I've made a few suggestions, they're primarily just nit picks. You've kept it so clean that I thought I might continue with your high standard. None of these are important, so I've given this an approval. Feel free to address the comments as you see fit and give me a ping
macladson
added
waiting-on-author
macladson
force-pushed
the
beacon-watch
branch
2 times, most recently
from
5444151 to
c237797
Compare
macladson
added
ready-for-review
paulhauner
approved these changes
Apr 3, 2023
paulhauner
added
ready-for-merge
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Apr 3, 2023
> This is currently a WIP and all features are subject to alteration or removal at any time. ## Overview The successor to #2873. Contains the backbone of `beacon.watch` including syncing code, the initial API, and several core database tables. See `watch/README.md` for more information, requirements and usage.
ghost
pushed a commit
to oone-world/lighthouse
that referenced
this pull request
Jul 13, 2023
> This is currently a WIP and all features are subject to alteration or removal at any time. ## Overview The successor to sigp#2873. Contains the backbone of `beacon.watch` including syncing code, the initial API, and several core database tables. See `watch/README.md` for more information, requirements and usage.
Woodpile37
pushed a commit
to Woodpile37/lighthouse
that referenced
this pull request
Jan 6, 2024
> This is currently a WIP and all features are subject to alteration or removal at any time. The successor to sigp#2873. Contains the backbone of `beacon.watch` including syncing code, the initial API, and several core database tables. See `watch/README.md` for more information, requirements and usage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
The successor to #2873.
Contains the backbone of
beacon.watchincluding syncing code, the initial API, and several core database tables.See
watch/README.mdfor more information, requirements and usage.