[Merged by Bors] - Add Ropsten configuration#3184
Closed
paulhauner wants to merge 2 commits intounstablefrom
Closed
[Merged by Bors] - Add Ropsten configuration#3184paulhauner wants to merge 2 commits intounstablefrom
paulhauner wants to merge 2 commits intounstablefrom
Conversation
Member
Author
|
|
paulhauner
added
ready-for-review
Member
|
Looks like the config was updated here eth-clients/merge-testnets@5b1b44a |
paulhauner
added
work-in-progress
Member
Author
That commit modifies shadow-fork-5, without touching ropsten. Thanks for point it out though! This PR is up-to-date with eth-clients/merge-testnets@5cbccd4 |
paulhauner
added
ready-for-review
Member
|
TTD is still subject to change, perhaps we should hold off merging until then? Or should we merge so we can roll out infra, and then ship an update as necessary? |
Member
Author
I think this is my preference, but not a strong one. |
michaelsproul
approved these changes
May 20, 2022
Member
michaelsproul
left a comment
michaelsproul
left a comment
There was a problem hiding this comment.
LGTM! Exciting to have a new network supported!
michaelsproul
added
ready-for-merge
Member
|
bors r+ |
bors Bot
pushed a commit
that referenced
this pull request
May 20, 2022
## Issue Addressed NA ## Proposed Changes Adds the configuration for the upcoming merge of the Ropsten network, as per: eth-clients/merge-testnets#9 Use the Ropsten network with: `lighthouse --network ropsten` ## Additional Info This is still a work-in-progress. We should wait for the eth-clients/merge-testnets PR to be approved before merging this into our `unstable`.
bors
Bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
NA
Proposed Changes
Adds the configuration for the upcoming merge of the Ropsten network, as per:
eth-clients/merge-testnets#9
Use the Ropsten network with:
lighthouse --network ropstenAdditional Info
This is still a work-in-progress. We should wait for the eth-clients/merge-testnets PR to be approved before merging this into our
unstable.