[Merged by Bors] - Remove lcli block packing analysis#3179
Closed
macladson wants to merge 2 commits intosigp:unstablefrom
Closed
[Merged by Bors] - Remove lcli block packing analysis#3179macladson wants to merge 2 commits intosigp:unstablefrom
macladson wants to merge 2 commits intosigp:unstablefrom
Conversation
michaelsproul
approved these changes
May 16, 2022
Member
michaelsproul
left a comment
michaelsproul
left a comment
There was a problem hiding this comment.
Awesome simplification, thanks!
michaelsproul
added
ready-for-merge
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
May 16, 2022
## Proposed Changes Remove the `lcli` code which performs block packing analysis. The `lcli` code has been deprecated by a more performant version available in the HTTP API added in #2879. ## Additional Info Any applications depending on the `lcli` code should migrate to the version in the HTTP API. The only feature which is unavailable in the API version is an estimate of live/dead validators. This was originally used to determine a closer approximation of block packing efficiencies since offline validators have a disproportionate impact on efficiencies. However the implimentation in `lcli` is a poor approximation which cannot account for a multitude of factors. It is recommended to simply calculate relative efficiencies instead or use a more advanced method of determining live/dead validators.
bors
bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Remove the
lclicode which performs block packing analysis.The
lclicode has been deprecated by a more performant version available in the HTTP API added in #2879.Additional Info
Any applications depending on the
lclicode should migrate to the version in the HTTP API.The only feature which is unavailable in the API version is an estimate of live/dead validators. This was originally used to determine a closer approximation of block packing efficiencies since offline validators have a disproportionate impact on efficiencies. However the implimentation in
lcliis a poor approximation which cannot account for a multitude of factors. It is recommended to simply calculate relative efficiencies instead or use a more advanced method of determining live/dead validators.