[Merged by Bors] - Kiln mev boost#3062
Closed
realbigsean wants to merge 73 commits intosigp:unstablefrom
Closed
Conversation
- `PrivateBeaconBlock` - `PrivateBeaconBlockBody` - `SignedPrivateBeaconBlock`
- GET lighthouse/validator/blocks_private endpoint
This reverts commit 5982466.
…neric-transactions � Conflicts: � Cargo.lock � consensus/state_processing/src/per_block_processing.rs � consensus/state_processing/src/per_block_processing/block_signature_verifier.rs � consensus/types/src/beacon_block.rs � consensus/types/src/beacon_block_body.rs � consensus/types/src/execution_payload.rs � testing/ef_tests/src/cases/operations.rs
Member
Author
|
I made some more parts of the |
- make it possible for jsonrpc id to be a string or an int
…ln-mev-boost � Conflicts: � beacon_node/beacon_chain/src/beacon_chain.rs � beacon_node/http_api/src/lib.rs � common/eth2/src/lib.rs
realbigsean
added
ready-for-review
5 tasks
michaelsproul
approved these changes
Mar 31, 2022
Member
michaelsproul
left a comment
michaelsproul
left a comment
There was a problem hiding this comment.
I'm happy to merge this!
| .message() | ||
| .body() | ||
| .sync_aggregate() | ||
| .unwrap() |
Member
There was a problem hiding this comment.
This unwrap isn't ideal, but I note that you've fixed it in #3134 and it isn't reachable from non-blinded block proposal routines, so I think we're good 👍
Member
Author
There was a problem hiding this comment.
Whoops, oversight on my part!
Member
|
Merging this so PRs built on top can target unstable bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Mar 31, 2022
## Issue Addressed MEV boost compatibility ## Proposed Changes See #2987 ## Additional Info This is blocked on the stabilization of a couple specs, [here](ethereum/beacon-APIs#194) and [here](flashbots/mev-boost#20). Additional TODO's and outstanding questions - [ ] MEV boost JWT Auth - [ ] Will `builder_proposeBlindedBlock` return the revealed payload for the BN to propogate - [ ] Should we remove `private-tx-proposals` flag and communicate BN <> VC with blinded blocks by default once these endpoints enter the beacon-API's repo? This simplifies merge transition logic. Co-authored-by: realbigsean <[email protected]> Co-authored-by: realbigsean <[email protected]>
paulhauner
pushed a commit
to paulhauner/lighthouse
that referenced
this pull request
Apr 4, 2022
## Issue Addressed MEV boost compatibility ## Proposed Changes See sigp#2987 ## Additional Info This is blocked on the stabilization of a couple specs, [here](ethereum/beacon-APIs#194) and [here](flashbots/mev-boost#20). Additional TODO's and outstanding questions - [ ] MEV boost JWT Auth - [ ] Will `builder_proposeBlindedBlock` return the revealed payload for the BN to propogate - [ ] Should we remove `private-tx-proposals` flag and communicate BN <> VC with blinded blocks by default once these endpoints enter the beacon-API's repo? This simplifies merge transition logic. Co-authored-by: realbigsean <[email protected]> Co-authored-by: realbigsean <[email protected]>
paulhauner
pushed a commit
to paulhauner/lighthouse
that referenced
this pull request
May 6, 2022
## Issue Addressed MEV boost compatibility ## Proposed Changes See sigp#2987 ## Additional Info This is blocked on the stabilization of a couple specs, [here](ethereum/beacon-APIs#194) and [here](flashbots/mev-boost#20). Additional TODO's and outstanding questions - [ ] MEV boost JWT Auth - [ ] Will `builder_proposeBlindedBlock` return the revealed payload for the BN to propogate - [ ] Should we remove `private-tx-proposals` flag and communicate BN <> VC with blinded blocks by default once these endpoints enter the beacon-API's repo? This simplifies merge transition logic. Co-authored-by: realbigsean <[email protected]> Co-authored-by: realbigsean <[email protected]>
bors bot
pushed a commit
that referenced
this pull request
Jul 29, 2022
## Issue Addressed #3091 Extends #3062, adding pre-bellatrix block support on blinded endpoints and allowing the normal proposal flow (local payload construction) on blinded endpoints. This resulted in better fallback logic because the VC will not have to switch endpoints on failure in the BN <> Builder API, the BN can just fallback immediately and without repeating block processing that it shouldn't need to. We can also keep VC fallback from the VC<>BN API's blinded endpoint to full endpoint. ## Proposed Changes - Pre-bellatrix blocks on blinded endpoints - Add a new `PayloadCache` to the execution layer - Better fallback-from-builder logic ## Todos - [x] Remove VC transition logic - [x] Add logic to only enable builder flow after Merge transition finalization - [x] Tests - [x] Fix metrics - [x] Rustdocs Co-authored-by: Mac L <[email protected]> Co-authored-by: realbigsean <[email protected]>
bors bot
pushed a commit
that referenced
this pull request
Jul 30, 2022
## Issue Addressed #3091 Extends #3062, adding pre-bellatrix block support on blinded endpoints and allowing the normal proposal flow (local payload construction) on blinded endpoints. This resulted in better fallback logic because the VC will not have to switch endpoints on failure in the BN <> Builder API, the BN can just fallback immediately and without repeating block processing that it shouldn't need to. We can also keep VC fallback from the VC<>BN API's blinded endpoint to full endpoint. ## Proposed Changes - Pre-bellatrix blocks on blinded endpoints - Add a new `PayloadCache` to the execution layer - Better fallback-from-builder logic ## Todos - [x] Remove VC transition logic - [x] Add logic to only enable builder flow after Merge transition finalization - [x] Tests - [x] Fix metrics - [x] Rustdocs Co-authored-by: Mac L <[email protected]> Co-authored-by: realbigsean <[email protected]>
bors bot
pushed a commit
that referenced
this pull request
Jul 30, 2022
## Issue Addressed #3091 Extends #3062, adding pre-bellatrix block support on blinded endpoints and allowing the normal proposal flow (local payload construction) on blinded endpoints. This resulted in better fallback logic because the VC will not have to switch endpoints on failure in the BN <> Builder API, the BN can just fallback immediately and without repeating block processing that it shouldn't need to. We can also keep VC fallback from the VC<>BN API's blinded endpoint to full endpoint. ## Proposed Changes - Pre-bellatrix blocks on blinded endpoints - Add a new `PayloadCache` to the execution layer - Better fallback-from-builder logic ## Todos - [x] Remove VC transition logic - [x] Add logic to only enable builder flow after Merge transition finalization - [x] Tests - [x] Fix metrics - [x] Rustdocs Co-authored-by: Mac L <[email protected]> Co-authored-by: realbigsean <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
MEV boost compatibility
Proposed Changes
See #2987
Additional Info
This is blocked on the stabilization of a couple specs, here and here.
Additional TODO's and outstanding questions
builder_proposeBlindedBlockreturn the revealed payload for the BN to propogateprivate-tx-proposalsflag and communicate BN <> VC with blinded blocks by default once these endpoints enter the beacon-API's repo? This simplifies merge transition logic.