[Merged by Bors] - Archive remote_signer code#2559
Closed
michaelsproul wants to merge 1 commit intosigp:unstablefrom
Closed
[Merged by Bors] - Archive remote_signer code#2559michaelsproul wants to merge 1 commit intosigp:unstablefrom
remote_signer code#2559michaelsproul wants to merge 1 commit intosigp:unstablefrom
Conversation
paulhauner
approved these changes
Sep 3, 2021
Member
paulhauner
left a comment
paulhauner
left a comment
There was a problem hiding this comment.
Yeah, good call. I was also planning to do this. The remote signer never quite managed to get off the ground unfortunately :( #2522 is going to solve our immediate remote signing needs and it doesn't require this code.
Member
Author
|
bors r+ |
michaelsproul
added
ready-for-merge
michaelsproul
force-pushed
the
archive-remote-signer
branch
from
0cd5ae4 to
ef05a4d
Compare
|
Canceled. |
Member
Author
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Sep 3, 2021
## Proposed Changes This PR deletes all `remote_signer` code from Lighthouse, for the following reasons: * The `remote_signer` code is unused, and we have no plans to use it now that we're moving to supporting the Web3Signer APIs: #2522 * It represents a significant maintenance burden. The HTTP API tests have been prone to platform-specific failures, and breakages due to dependency upgrades, e.g. #2400. Although the code is deleted it remains in the Git history should we ever want to recover it. For ease of reference: - The last commit containing remote signer code: 5a3bcd2 - The last Lighthouse version: v1.5.1
|
Pull request successfully merged into unstable. Build succeeded: |
bors
bot
changed the title
remote_signer coderemote_signer code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This PR deletes all
remote_signercode from Lighthouse, for the following reasons:remote_signercode is unused, and we have no plans to use it now that we're moving to supporting the Web3Signer APIs: [Merged by Bors] - Web3Signer support for VC #2522Although the code is deleted it remains in the Git history should we ever want to recover it. For ease of reference: