[Merged by Bors] - Implement slasher#1567
Conversation
michaelsproul
force-pushed
the
slasher
branch
2 times, most recently
from
2b3c1a6 to
039b066
Compare
This is faster, and pushes a lot of the work into tree hashing, which we might be able to optimise.
paulhauner
left a comment
paulhauner
left a comment
There was a problem hiding this comment.
This is an impressive research and engineering piece! It was a pleasure to read and a real contribution to Lighthouse and Eth2 🥇
I must admit I'm not 100% across the theory of the schema, but I don't think that should prevent a merge. The slasher is a best-effort component; as long as it does not crash then it is better than nothing. That being said, I see no reason to believe this implementation is lacking.
Although I'm not fully across the slasher theory, I did go through the whole implementation and have left several comments and suggestions. I would be happy to merge
🚀
paulhauner
added
work-in-progress
|
This is ready for re-review and merge IMO. The only outstanding issue is #1890, which I'll try to get to before 1.0, but isn't a blocker for users running with the default configuration, or experienced users (who can drop their DB if they set a max DB size too low). |
michaelsproul
added
ready-for-review
|
Will fix the merge conflict ASAP, just finishing off some slashing protection stuff |
paulhauner
left a comment
paulhauner
left a comment
There was a problem hiding this comment.
Awesome, LGTM!
Happy for you to bors whenever, assuming merge conflict change is trivial :)
|
Indeed the merge commit was trivial (97228b5) I can't believe we're finally merging this 😮 😮 😮 🚀 🚀 🚀 🚀 🚀 🚀 🚀 🚀 🚀 🚀 🚀 🚀 🚀 Summoning Señor Bors... bors r+ |
This is an implementation of a slasher that lives inside the BN and can be enabled via `lighthouse bn --slasher`. Features included in this PR: - [x] Detection of attester slashing conditions (double votes, surrounds existing, surrounded by existing) - [x] Integration into Lighthouse's attestation verification flow - [x] Detection of proposer slashing conditions - [x] Extraction of attestations from blocks as they are verified - [x] Compression of chunks - [x] Configurable history length - [x] Pruning of old attestations and blocks - [x] More tests Future work: * Focus on a slice of history separate from the most recent N epochs (e.g. epochs `current - K` to `current - M`) * Run out-of-process * Ingest attestations from the chain without a resync Design notes are here https://hackmd.io/@sproul/HJSEklmPL
michaelsproul
added
ready-for-merge
|
Pull request successfully merged into master. Build succeeded: |
2 participants
This is an implementation of a slasher that lives inside the BN and can be enabled via
lighthouse bn --slasher.Features included in this PR:
Future work:
current - Ktocurrent - M)Design notes are here https://hackmd.io/@sproul/HJSEklmPL