Fix nodes_without_children

dapplion · dapplion · commit b9d8ae74b127 · 2025-02-04T16:15:44.000-03:00
diff --git a/beacon_node/beacon_chain/src/test_utils.rs b/beacon_node/beacon_chain/src/test_utils.rs
@@ -900,7 +900,15 @@ where
     pub fn assert_knows_head(&self, head_block_root: Hash256) {
         let heads = self.chain.heads().unwrap();
         if !heads.iter().any(|head| head.0 == head_block_root) {
-            panic!("Expected to known head block root {head_block_root:?}, known heads {heads:?}");
+            let fork_choice = self.chain.canonical_head.fork_choice_read_lock();
+            if heads.is_empty() {
+                let nodes = fork_choice.proto_array().core_proto_array().nodes;
+                panic!("Expected to known head block root {head_block_root:?}, but heads is empty. Nodes: {nodes:#?}");
+            } else {
+                panic!(
+                    "Expected to known head block root {head_block_root:?}, known heads {heads:#?}"
+                );
+            }
         }
     }
 
diff --git a/consensus/proto_array/src/proto_array.rs b/consensus/proto_array/src/proto_array.rs
@@ -1062,6 +1062,9 @@ impl ProtoArray {
     fn nodes_without_children(&self) -> Vec<usize> {
         let mut childs_of = HashMap::<_, Vec<_>>::new();
         for (index, node) in self.nodes.iter().enumerate() {
+            // Create entry for this node
+            childs_of.entry(index).or_default();
+            // Add this node to the parent's child list if any
             if let Some(parent_index) = node.parent {
                 childs_of.entry(parent_index).or_default().push(index);
             }
