Remove some stale FIXMEs/typos

michaelsproul · michaelsproul · commit 80a53533ff59 · 2025-05-29T17:28:49.000+10:00
diff --git a/beacon_node/beacon_chain/src/schema_change/migration_schema_v24.rs b/beacon_node/beacon_chain/src/schema_change/migration_schema_v24.rs
@@ -345,7 +345,7 @@ pub fn upgrade_to_v24<T: BeaconChainTypes>(
 
                         // Store immediately so that future diffs can load and diff from it.
                         let mut ops = vec![];
-                        // We must commit the hot state summary immediatelly, otherwise we can't diff
+                        // We must commit the hot state summary immediately, otherwise we can't diff
                         // against it and future writes will fail. That's why we write the new hot
                         // summaries in a different column to have both new and old data present at
                         // once. Otherwise if the process crashes during the migration the database will
diff --git a/beacon_node/beacon_chain/tests/store_tests.rs b/beacon_node/beacon_chain/tests/store_tests.rs
@@ -3185,7 +3185,6 @@ async fn schema_downgrade_to_min_version_full_node_per_epoch_diffs() {
 }
 
 // Schema upgrade/downgrade on a full node with dense per-slot diffs.
-// FIXME(tree-states): this will panic
 #[tokio::test]
 async fn schema_downgrade_to_min_version_full_node_dense_diffs() {
     schema_downgrade_to_min_version(
diff --git a/beacon_node/store/src/hot_cold_store.rs b/beacon_node/store/src/hot_cold_store.rs
@@ -1662,7 +1662,6 @@ impl<E: EthSpec, Hot: ItemStore<E>, Cold: ItemStore<E>> HotColdDB<E, Hot, Cold>
 
         match self.hot_storage_strategy(slot)? {
             StorageStrategy::Snapshot => {
-                // FIXME(tree-states): rename error
                 let Some(state) = self.load_hot_state_as_snapshot(state_root)? else {
                     let existing_snapshots = self.load_hot_state_snapshot_roots()?;
                     // TODO(hdiff): this log is for debug and can include a very long list of roots,
@@ -3483,9 +3482,6 @@ pub fn get_ancestor_state_root<'a, E: EthSpec, Hot: ItemStore<E>, Cold: ItemStor
     // traversing the sparse portion of the hdiff grid (prior to the split slot). It is also
     // necessary for the v24 schema migration on archive nodes, where there isn't yet any grid
     // to traverse.
-    //
-    // FIXME(tree-states): still need to add logic below to somehow traverse the grid on non-archive
-    // nodes.
     if target_slot < split.slot && target_slot >= state_upper_limit {
         drop(split);
         return store

Original file line number	Diff line number	Diff line change
`@@ -3185,7 +3185,6 @@ async fn schema_downgrade_to_min_version_full_node_per_epoch_diffs() {`
`3185`	`3185`	`}`
`3186`	`3186`
`3187`	`3187`	`// Schema upgrade/downgrade on a full node with dense per-slot diffs.`
`3188`		`-// FIXME(tree-states): this will panic`
`3189`	`3188`	`#[tokio::test]`
`3190`	`3189`	`async fn schema_downgrade_to_min_version_full_node_dense_diffs() {`
`3191`	`3190`	`schema_downgrade_to_min_version(`