Remove/document remaining Electra TODOs

michaelsproul · michaelsproul · commit 639a9215a991 · 2025-02-11T17:24:11.000+11:00
diff --git a/beacon_node/execution_layer/src/lib.rs b/beacon_node/execution_layer/src/lib.rs
@@ -209,6 +209,7 @@ pub enum BlockProposalContents<E: EthSpec, Payload: AbstractExecPayload<E>> {
         /// `None` for blinded `PayloadAndBlobs`.
         blobs_and_proofs: Option<(BlobsList<E>, KzgProofs<E>)>,
         // TODO(electra): this should probably be a separate variant/superstruct
+        // See: https://github.com/sigp/lighthouse/issues/6981
         requests: Option<ExecutionRequests<E>>,
     },
 }
diff --git a/consensus/state_processing/src/genesis.rs b/consensus/state_processing/src/genesis.rs
@@ -123,8 +123,7 @@ pub fn initialize_beacon_state_from_eth1<E: EthSpec>(
         // Remove intermediate Deneb fork from `state.fork`.
         state.fork_mut().previous_version = spec.electra_fork_version;
 
-        // TODO(electra): think about this more and determine the best way to
-        // do this. The spec tests will expect that the sync committees are
+        // The spec tests will expect that the sync committees are
         // calculated using the electra value for MAX_EFFECTIVE_BALANCE when
         // calling `initialize_beacon_state_from_eth1()`. But the sync committees
         // are actually calcuated back in `upgrade_to_altair()`. We need to
diff --git a/consensus/state_processing/src/per_block_processing/verify_attestation.rs b/consensus/state_processing/src/per_block_processing/verify_attestation.rs
@@ -63,7 +63,7 @@ pub fn verify_attestation_for_state<'ctxt, E: EthSpec>(
 ) -> Result<IndexedAttestationRef<'ctxt, E>> {
     let data = attestation.data();
 
-    // TODO(electra) choosing a validation based on the attestation's fork
+    // NOTE: choosing a validation based on the attestation's fork
     // rather than the state's fork makes this simple, but technically the spec
     // defines this verification based on the state's fork.
     match attestation {
diff --git a/consensus/types/src/validator.rs b/consensus/types/src/validator.rs
@@ -249,7 +249,6 @@ impl Validator {
         }
     }
 
-    /// TODO(electra): refactor these functions and make it simpler.. this is a mess
     /// Returns `true` if the validator is partially withdrawable.
     fn is_partially_withdrawable_validator_capella(&self, balance: u64, spec: &ChainSpec) -> bool {
         self.has_eth1_withdrawal_credential(spec)

Original file line number	Diff line number	Diff line change
`@@ -209,6 +209,7 @@ pub enum BlockProposalContents<E: EthSpec, Payload: AbstractExecPayload<E>> {`
`209`	`209`	/// `None` for blinded `PayloadAndBlobs`.
`210`	`210`	`blobs_and_proofs: Option<(BlobsList<E>, KzgProofs<E>)>,`
`211`	`211`	`// TODO(electra): this should probably be a separate variant/superstruct`
	`212`	`+ // See: https://github.com/sigp/lighthouse/issues/6981`
`212`	`213`	`requests: Option<ExecutionRequests<E>>,`
`213`	`214`	`},`
`214`	`215`	`}`
Original file line number	Diff line number	Diff line change
`@@ -249,7 +249,6 @@ impl Validator {`
`249`	`249`	`}`
`250`	`250`	`}`
`251`	`251`
`252`		`- /// TODO(electra): refactor these functions and make it simpler.. this is a mess`
`253`	`252`	/// Returns `true` if the validator is partially withdrawable.
`254`	`253`	`fn is_partially_withdrawable_validator_capella(&self, balance: u64, spec: &ChainSpec) -> bool {`
`255`	`254`	`self.has_eth1_withdrawal_credential(spec)`