Context propagation for sql server#2348
Merged
Merged
Conversation
laurit
marked this pull request as ready for review
July 9, 2025 12:11
robsunday
approved these changes
Jul 9, 2025
breedx-splk
reviewed
Jul 9, 2025
| } | ||
| } | ||
|
|
||
| /** |
Contributor
There was a problem hiding this comment.
This whole block aligns us with the upstream conventions. Just remarking for any other curious readers.
breedx-splk
reviewed
Jul 9, 2025
breedx-splk
reviewed
Jul 9, 2025
breedx-splk
reviewed
Jul 9, 2025
breedx-splk
approved these changes
Jul 9, 2025
breedx-splk
left a comment
breedx-splk
left a comment
Contributor
There was a problem hiding this comment.
Looks good. Had a couple small things, but nothing to hold this up. The use of CallDepth took a little bit to get my head around, especially how it's manipulated by the tests...but I think I grok it. I appreciate the thoroughness in the tests!
Let's give it a shot! 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on open-telemetry/opentelemetry-dotnet-contrib#2709