Repository navigation
brief(phase4) + scaffold: PR-5 phase 0 follow-up - #25
Merged
Merged
Conversation
Phase 0 bare-repro (PR #24) confirmed three upstream HF 0.4.41 bugs. PR-5 lands the orchestrator-side reactions: 1. Brief: sub-composition split block changed from "strong recommendation / SHOULD" to "BLOCKED pending upstream fix". The canon-blessed <template> + data-composition-src pattern produces black renders in HF 0.4.41; do not split beats into sub-comps until upstream loader unwraps <template>.content. Tracks upstream issue heygen-com/hyperframes#589. 2. Q3 scaffold workaround: verified via grep — scripts/ and .claude/commands/ do not emit the literal "repeat:-1" in comments, so no scaffold patch needed (YAGNI). Filed two upstream issues: - heygen-com/hyperframes#589 — sub-comp loader / compositions CLI vs <template> - heygen-com/hyperframes#590 — lint regex false-positive on JS comments Step 9 (held memory writes) follows. Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/and.claude/commands/— no scaffold patch needed (YAGNI).Upstream issues filed
<template>wrapper)Canon respect
Brief change does not edit canon. The block now explicitly cites the broken canon-blessed pattern + the upstream issue tracking the fix. Once upstream merges + we bump HF version, this block reverts to the imperative "MUST split for ≥3 beats" form (tracked in memory).
Test plan
🤖 Generated with Claude Code