Repository navigation
Conversation
The --k8s-endpoint flag was defined but never used in the rotate-ca command. This fix passes the flag value through to the Kubernetes client, allowing users to override the default Kubernetes API endpoint during CA rotation. Co-Authored-By: Claude <[email protected]> Signed-off-by: Andrei Kvapil <[email protected]>
Member
|
Forking this PR as I can't push back to org branches. |
lexfrei
added a commit
to cozystack/talm
that referenced
this pull request
Apr 10, 2026
Remove reference to siderolabs/talos#12644 (--k8s-endpoint), which was closed in favor of #12669 and merged upstream. The remaining driver for the fork is #12652 (--skip-verify), which upstream declined on security grounds, so the fork is required for as long as we need that flag. Signed-off-by: Aleksei Sviridkin <[email protected]>
lexfrei
added a commit
to cozystack/talm
that referenced
this pull request
Apr 10, 2026
Routine dependency bump pass with code modernization.
Go toolchain:
- go: 1.25.6 -> 1.26.2
Direct Go dependencies:
- k8s.io/{api,apimachinery,client-go}: v0.35.0 -> v0.35.3
- github.com/cosi-project/runtime: v1.13.0 -> v1.14.1
- github.com/siderolabs/crypto: v0.6.4 -> v0.6.5
- github.com/siderolabs/talos/pkg/machinery: v1.13.0-alpha.0 -> v1.13.0-beta.1
- github.com/siderolabs/talos: v1.12.2 -> v1.12.6
- github.com/spf13/cobra: v1.10.1 -> v1.10.2
- google.golang.org/grpc: v1.77.0 -> v1.80.0 (closes CVE-2026-33186)
- filippo.io/age: v1.2.1 -> v1.3.1
- github.com/BurntSushi/toml: v1.5.0 -> v1.6.0
- helm.sh/helm/v3: v3.19.5 -> v3.20.2
k8s.io indirect lockstep to v0.35.3:
- apiextensions-apiserver, apiserver, cli-runtime, component-base,
component-helpers, kms, kubectl
Indirect security fixes:
- github.com/docker/cli: v29.1.3 -> v29.4.0 (closes CVE-2025-15558)
- github.com/cloudflare/circl: v1.6.1 -> v1.6.3 (closes CVE-2026-1229)
Round-2 bumps unblocked by Go 1.26:
- github.com/siderolabs/go-kubeconfig: v0.1.1 -> v0.1.2
- github.com/siderolabs/go-talos-support: v0.1.4 -> v0.2.0
327 additional indirect dependency updates applied across two passes via
targeted go get (each change validated with go build).
GitHub Actions:
- actions/checkout: v4 -> v6
- actions/setup-go: v5 -> v6
- goreleaser/goreleaser-action: v6 -> v7
Renovate config:
- Add .github/renovate.json with config:recommended preset and a custom
regex manager surfacing helm.sh/helm v3 -> v4 upgrade proposals. The
config is inert until the Renovate GitHub App is installed.
Fork replace rationale:
- Update go.mod comment to reference only siderolabs/talos#12652
(--skip-verify, declined upstream). The previous siderolabs/talos#12644
(--k8s-endpoint) reference is stale since #12669 was merged upstream.
Code modernization:
- gopls modernize and go fix across the codebase: interface{} -> any,
maps.Copy, slices.Contains, gofmt cleanup. No behavior changes.
Bug fix:
- Guard initConfig() against missing os.Args[1] to prevent panic on
plain `talm` invocation with no arguments.
Assisted-By: Claude <[email protected]>
Signed-off-by: Aleksei Sviridkin <[email protected]>
lexfrei
added a commit
to cozystack/talm
that referenced
this pull request
Apr 14, 2026
Routine dependency bump pass with code modernization.
Go toolchain:
- go: 1.25.6 -> 1.26.2
Direct Go dependencies:
- k8s.io/{api,apimachinery,client-go}: v0.35.0 -> v0.35.3
- github.com/cosi-project/runtime: v1.13.0 -> v1.14.1
- github.com/siderolabs/crypto: v0.6.4 -> v0.6.5
- github.com/siderolabs/talos/pkg/machinery: v1.13.0-alpha.0 -> v1.13.0-beta.1
- github.com/siderolabs/talos: v1.12.2 -> v1.12.6
- github.com/spf13/cobra: v1.10.1 -> v1.10.2
- google.golang.org/grpc: v1.77.0 -> v1.80.0 (closes CVE-2026-33186)
- filippo.io/age: v1.2.1 -> v1.3.1
- github.com/BurntSushi/toml: v1.5.0 -> v1.6.0
- helm.sh/helm/v3: v3.19.5 -> v3.20.2
k8s.io indirect lockstep to v0.35.3:
- apiextensions-apiserver, apiserver, cli-runtime, component-base,
component-helpers, kms, kubectl
Indirect security fixes:
- github.com/docker/cli: v29.1.3 -> v29.4.0 (closes CVE-2025-15558)
- github.com/cloudflare/circl: v1.6.1 -> v1.6.3 (closes CVE-2026-1229)
Round-2 bumps unblocked by Go 1.26:
- github.com/siderolabs/go-kubeconfig: v0.1.1 -> v0.1.2
- github.com/siderolabs/go-talos-support: v0.1.4 -> v0.2.0
327 additional indirect dependency updates applied across two passes via
targeted go get (each change validated with go build).
GitHub Actions:
- actions/checkout: v4 -> v6
- actions/setup-go: v5 -> v6
- goreleaser/goreleaser-action: v6 -> v7
Renovate config:
- Add .github/renovate.json with config:recommended preset and a custom
regex manager surfacing helm.sh/helm v3 -> v4 upgrade proposals. The
config is inert until the Renovate GitHub App is installed.
Fork replace rationale:
- Update go.mod comment to reference only siderolabs/talos#12652
(--skip-verify, declined upstream). The previous siderolabs/talos#12644
(--k8s-endpoint) reference is stale since #12669 was merged upstream.
Code modernization:
- gopls modernize and go fix across the codebase: interface{} -> any,
maps.Copy, slices.Contains, gofmt cleanup. No behavior changes.
Bug fix:
- Guard initConfig() against missing os.Args[1] to prevent panic on
plain `talm` invocation with no arguments.
Assisted-By: Claude <[email protected]>
Signed-off-by: Aleksei Sviridkin <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What? (description)
Pass the
--k8s-endpointflag value to the Kubernetes client during CA rotation.The flag was defined in the CLI but never actually used - the value was stored in
rotateCACmdFlags.forceEndpointbut not passed tokubernetes.Options, so the Kubernetes client always used the default endpoint from kubeconfig.Why? (reasoning)
When rotating Kubernetes CA on a cluster behind NAT or with a virtual IP that is not directly accessible, users need to specify an alternative endpoint. Without this fix, the
--k8s-endpointflag has no effect and the rotation fails trying to connect to the unreachable default endpoint.Acceptance
Please use the following checklist:
make conformance)make fmt)make lint)make docs)make unit-tests)